topic/RDKEMW6161 devicesettings src changes

[rababu2]

No description provided.

[Copilot]

Pull Request Overview

This PR implements a device settings source code restructuring related to RDKEMW6161, primarily introducing event notification interfaces and IARM implementation for composite input handling. The changes establish a new notification header file and add event management capabilities across multiple device classes.

• Added comprehensive enums and typedefs for device settings notifications in a new header file
• Introduced event listener interfaces for video, audio, HDMI, composite input, display, and host components
• Implemented IARM-based composite input event handling with proper registration/unregistration mechanisms

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
rpc/include/dsMgrNtf.h	New header defining enums and typedefs for audio, video, HDMI, composite, display events and capabilities
ds/videoOutputPort.cpp	Added stub Register/UnRegister event methods with copyright update
ds/videoDevice.cpp	Added stub Register/UnRegister event methods with copyright update
ds/include/videoOutputPort.hpp	Added IEvent interface for resolution, HDCP, and video format events
ds/include/videoDevice.hpp	Added IEvent interface for display framerate change events
ds/include/iarm/iarmCompositeIn.hpp	New IARM composite input class with event handling capabilities
ds/include/host.hpp	Added IEvent interface for sleep mode changes
ds/include/hdmiIn.hpp	Added comprehensive IEvent interface for HDMI input events
ds/include/frontPanelTextDisplay.hpp	Added IEvent interface for time format changes
ds/include/displayConnectionChangeListener.hpp	Added event interfaces for display connection and HDCP events
ds/include/compositeIn.hpp	Added IEvent interface and IARM implementation integration
ds/include/audioOutputPort.hpp	Added comprehensive IEvent interface for audio events
ds/iarm/iarmCompositeIn.cpp	Complete IARM implementation for composite input event handling
ds/host.cpp	Added stub implementations for various Register/UnRegister methods
ds/hdmiIn.cpp	Added stub Register/UnRegister methods with copyright update
ds/frontPanelConfig.cpp	Added stub Register/UnRegister methods for front panel display
ds/compositeIn.cpp	Integrated IARM implementation with proper lifecycle management
ds/audioOutputPort.cpp	Added stub Register/UnRegister methods
ds/Makefile.am	Added conditional compilation for IARM path
ds/Makefile	Updated include paths for IARM directory

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Using std::string in a C header file is problematic. The file uses extern "C" but includes C++ types, which can cause compilation issues when included from C code.

Suggested change

	std::string name;
	char name[256];

[Copilot]

Using std::string in a C header file is problematic. The file uses extern "C" but includes C++ types, which can cause compilation issues when included from C code.

Suggested change

	}DisplayVideoPortResolution;
	#define DS_MAX_NAME_LEN 256
	typedef struct _DisplayVideoPortResolution {
	char name[DS_MAX_NAME_LEN];
	DisplayTVResolution pixelResolution;
	DisplayVideoAspectRatio aspectRatio;
	DisplayInVideoStereoScopicMode stereoScopicMode;
	DisplayInVideoFrameRate frameRate;
	bool interlaced;
	}DisplayVideoPortResolution;

[Copilot]

This pure virtual function (= 0) is inconsistent with other virtual functions in the IEvent interface that have default empty implementations. This will force all implementers to provide this method.

Suggested change

	virtual void OnCompositeInVideoModeUpdate(CompositeInPort activePort, DisplayVideoPortResolution videoResolution) = 0;
	virtual void OnCompositeInVideoModeUpdate(CompositeInPort activePort, DisplayVideoPortResolution videoResolution) { };

[Copilot]

The log message says 'Register Entry' but this is in the UnRegister function. It should say 'UnRegister Entry'.

Suggested change

	INT_INFO("CompositeInput::Register Entry \n");
	INT_INFO("CompositeInput::UnRegister Entry \n");

[Copilot]

The function comment incorrectly refers to 'CompositeInput::UnRegister' when this is actually 'HdmiInput::UnRegister'.

Suggested change

	* @fn void CompositeInput::UnRegister(IEvent *listener)
	* @fn void HdmiInput::UnRegister(IEvent *listener)