RDKCOM-5438: RDKBDEV-3293 Fix Condition check for adding default IPv6 route in WANManager #150
Conversation
|
|
||
| buffer[0] = '\0'; | ||
| if ((fp_route = popen("ip -6 ro | grep default", "r"))) { | ||
| if ((fp_route = popen("ip -6 ro show default dev erouter0", "r"))) { |
There was a problem hiding this comment.
p_VirtIf->Name should be used instead of hard-coding erouter0.
Could you please clarify how this change addresses the IPv6 router issue?
does the MXL platform have a different default IPv6 router apart from the WAN interface in this scenario?"
There was a problem hiding this comment.
yes, correct.
This is observed in MXL platform because we have default IPv6 route present for wan0(for Docsis Management) apart from that of erouter0 in CM.
So, this condition check is not enough to add default erouter0 route and thus default route for erouter0 is missing in MXL setup.
To fix this, we have modified the condition check in code to add route for erouter0 irrespective of any other default route in CM.
There was a problem hiding this comment.
Okay.
Could you please change the hardcoded erouter0 to "p_VirtIf->Name" ?
There was a problem hiding this comment.
Hi, addressed the review comment @S-Parthiban-Selvaraj
Sorry the delay in response. I was occupied with a bit high priority work in our platform so far.
There was a problem hiding this comment.
@aprasad-97
Thanks for the update. The changes look good. We will bring this change in the next release.
pradeeptakdas
changed the title
aprasad-97
force-pushed
the
RDKBDEV-3293
branch
2 times, most recently
from
191c6f7 to
4d47111
Compare
…ANManager Reason for change: After enabling Wan Manager Unification flag in MXL build, we observed that default IPv6 route for erouter0 was not getting added in CM during bootup. So fixed condition check to specifically check erouter0 interface while adding route. Risks: Low Signed-off-by: Aiswarya Prasad <[email protected]>
aprasad-97
force-pushed
the
RDKBDEV-3293
branch
from
4d47111 to
d781ebd
Compare
2 participants
Reason for change: After enabling Wan Manager Unification flag in MXL build, we observed that default IPv6 route for erouter0 was not getting added in CM during bootup. So fixed condition check to specifically check erouter0 interface while adding route.
Risks: Low
Signed-off-by: Aiswarya Prasad [email protected]