RDKB-60436 : Cold Standby Support in WAN Manager for WiFi Hotspot Failover. #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in activating state. (#166) Reason for change: As part of RDKB-59763 US, we have supported SLAAC IPv6 support in WanManager but that new flag has not been handled as part of t2 profile due to the reason we seen crash. so to avoid this crash I have handled this in t2 profile parsing during t2 event send. Test Procedure: 1. WANManager should not crash and should work without any issue. Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <[email protected]>
…lover. Reason for change: RDKB-59763 - Develop that US acceptance criteria. Test Procedure: Build should passed WANManager functionality should work without any issue Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <[email protected]>
Copilot started reviewing on behalf of
LakshminarayananShenbagaraj
November 28, 2025 14:26
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements Cold Standby Support in WAN Manager for WiFi Hotspot Failover (RDKB-60436). The change relocates WAN initialization logging from the wan_state_phy_down state to the wan_transition_vlan_configure transition function, moving it earlier in the WAN state machine flow to better align with VLAN configuration timing.
Key changes:
- Moved WAN_INIT_START boot event logging and
Update_Interface_Status()call fromwan_state_phy_downtowan_transition_vlan_configure - Variable declarations (
uptime,buffer) moved to support the relocated logging code
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
guto86
approved these changes
Nov 28, 2025
S-Parthiban-Selvaraj
approved these changes
Dec 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview:
This PR implements Cold Standby Support in WAN Manager for WiFi Hotspot Failover (RDKB-60436). The change relocates WAN initialization logging from the wan_state_phy_down state to the wan_transition_vlan_configure transition function, moving it earlier in the WAN state machine flow to better align with VLAN configuration timing.
Key changes:
Moved WAN_INIT_START boot event logging and Update_Interface_Status() call from wan_state_phy_down to wan_transition_vlan_configure
Variable declarations (uptime, buffer) moved to support the relocated logging code
Signed-off-by: LakshminarayananShenbagaraj [email protected]