feat(projects): add check for finding next relevant page #1192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyPyDavid
force-pushed
the
1191-interview-slow-loading-on-proceed-when-a-lot-of-conditional-pages-are-skipped
branch
from
9796e9e to
f3b8850
Compare
MyPyDavid
force-pushed
the
1191-interview-slow-loading-on-proceed-when-a-lot-of-conditional-pages-are-skipped
branch
from
f3b8850 to
9756d2c
Compare
MyPyDavid
force-pushed
the
1191-interview-slow-loading-on-proceed-when-a-lot-of-conditional-pages-are-skipped
branch
from
3e06cd8 to
c90ea63
Compare
MyPyDavid
force-pushed
the
1191-interview-slow-loading-on-proceed-when-a-lot-of-conditional-pages-are-skipped
branch
from
c90ea63 to
f788af7
Compare
Signed-off-by: David Wallace <[email protected]>
MyPyDavid
force-pushed
the
1191-interview-slow-loading-on-proceed-when-a-lot-of-conditional-pages-are-skipped
branch
from
f4d75ac to
6f8244e
Compare
jochenklar
requested changes
Nov 29, 2024
Member
jochenklar
left a comment
jochenklar
left a comment
There was a problem hiding this comment.
Awesome, works nicely. Do we test this? Otherwise only style feedback.
| values = self.project.values.filter(snapshot=None).select_related('attribute', 'option') | ||
|
|
||
| if check_conditions(conditions, values): | ||
| sets = compute_sets(values) |
Member
There was a problem hiding this comment.
I wonder how much more expensive this is. In the future we could move functions like compute_sets to the manager. Just having ideas...
Member
Author
|
ok thanks! Yes think that a certain specific test case would be maybe appropriate here, I'll add one. |
Signed-off-by: David Wallace <[email protected]>
Signed-off-by: David Wallace <[email protected]>
Member
Author
|
when tests pass, it's ready for review/merge |
jochenklar
requested changes
Dec 3, 2024
Signed-off-by: David Wallace <[email protected]>
jochenklar
requested changes
Dec 3, 2024
rdmo/projects/progress.py
Outdated
| ) | ||
|
|
||
| # If no current_page, return None | ||
| if not current_page: |
Member
There was a problem hiding this comment.
some current_page need to be renamed to next_page
Member
Author
There was a problem hiding this comment.
snap, thanks! Ive updated it now.
Member
Author
There was a problem hiding this comment.
yes, now also with comments
Signed-off-by: David Wallace <[email protected]>
MyPyDavid
force-pushed
the
1191-interview-slow-loading-on-proceed-when-a-lot-of-conditional-pages-are-skipped
branch
from
59f80bd to
365b892
Compare
MyPyDavid
deleted the
1191-interview-slow-loading-on-proceed-when-a-lot-of-conditional-pages-are-skipped
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue: #1191
Adds the method
compute_next_relevant_pageinprogress.py.Refactors
compute_show_pageto be able to re-used inProjectPageViewSetfor finding the next relevant page.Motivation and Context
How has this been tested?
Screenshots (if appropriate)