Skip to content

remove reactDOM.findDOMNode usage #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshbalfour
Copy link

React 19 removed ReactDOM.findDOMNode: https://18.react.dev/reference/react-dom/findDOMNode
This update follows their recommended alternative method.

@mlazari
Copy link

mlazari commented Jul 28, 2025

Any plans on releasing this? I am getting a _reactDom.default.findDOMNode is not a function error in a storybook that uses this dependency after updating to React Native 0.79.5 / React 19.0.0. I can confirm that this change fixes the error for me, I tested it by applying a patch with these changes: react-native-web-lottie+1.4.4.patch

Copy link

@mlazari mlazari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only thing I would change is to move the createRef import to the first line:

import React, { createRef, PureComponent } from 'react';

Copy link

@xlecunff-pass xlecunff-pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the library seems to be dead :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants