Skip to content

[LogBox] Parse bundling errors from Metro Dev Server and avoid symbolicating them #53452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krystofwoldrich wants to merge 5 commits into from
Closed

[LogBox] Parse bundling errors from Metro Dev Server and avoid symbolicating them #53452

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8997dd0
[LogBox] Parse bundling errors from Metro Dev Server and avoid symbol…
krystofwoldrich Aug 25, 2025
47cc670
Revert "[LogBox] Parse bundling errors from Metro Dev Server and avoi…
krystofwoldrich Aug 26, 2025
7db31e2
fix the issue in hmrclient
krystofwoldrich Aug 26, 2025
1dfa91a
fix flow type checking issues
krystofwoldrich Oct 16, 2025
93ac7db
fix eslint warnings
krystofwoldrich Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions packages/react-native/Libraries/Utilities/HMRClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
* @format
*/

import type {ExtendedError} from '../Core/ExtendedError';

import getDevServer from '../Core/Devtools/getDevServer';
import LogBox from '../LogBox/LogBox';
import NativeRedBox from '../NativeModules/specs/NativeRedBox';
Expand Down Expand Up @@ -349,25 +347,27 @@ function dismissRedbox() {
}

function showCompileError() {
if (currentCompileErrorMessage === null) {
const message = currentCompileErrorMessage;
if (message === null) {
return;
}

// Even if there is already a redbox, syntax errors are more important.
// Otherwise you risk seeing a stale runtime error while a syntax error is more recent.
dismissRedbox();

const message = currentCompileErrorMessage;
currentCompileErrorMessage = null;

/* $FlowFixMe[class-object-subtyping] added when improving typing for this
* parameters */
// $FlowFixMe[incompatible-type]
const error: ExtendedError = new Error(message);
// Symbolicating compile errors is wasted effort
// because the stack trace is meaningless:
error.preventSymbolication = true;
throw error;
LogBox.addException({
message: message,
originalMessage: message,
name: undefined,
componentStack: undefined,
stack: [],
id: -1,
isFatal: true,
isComponentError: false,
});
}

export default HMRClient;
Loading