Fix visual artifacts when sometimes using decimal assymetric borderRadii#54237
Closed
jorge-cab wants to merge 1 commit into
Closed
Fix visual artifacts when sometimes using decimal assymetric borderRadii#54237jorge-cab wants to merge 1 commit into
jorge-cab wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@jorge-cab has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85260693. |
jorge-cab
force-pushed
the
export-D85260693
branch
2 times, most recently
from
3614f20 to
1507fa5
Compare
jorge-cab
force-pushed
the
export-D85260693
branch
from
1507fa5 to
da10ad1
Compare
jorge-cab
force-pushed
the
export-D85260693
branch
from
da10ad1 to
aef3ff9
Compare
…dii (react#54237) Summary: Before we were adding a single pixel for the stretchable area. in RCTViewComponentView we calculate what percentage is 1 pixel from the entire image to create the unit rectangle: ``` CGRect contentsCenter = CGRect{ CGPoint{imageCapInsets.left / imageSize.width, imageCapInsets.top / imageSize.height}, CGSize{(CGFloat)1.0 / imageSize.width, (CGFloat)1.0 / imageSize.height}}; ``` However sometimes when dividing `1.0 / imageSize.width` we would get a big enough float that causes a rounding error essentially having part of the border bleed into the stretchable region. The easiest way to fix this is give the stretchable region a little more space so to prevent the bleeding. We can do this by rounding the edgeInsets that give the border area its size The alternative is some shockingly complex math to appropriately calculate the most convenient stretchable area size Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D85260693
jorge-cab
force-pushed
the
export-D85260693
branch
from
aef3ff9 to
eb42525
Compare
|
This pull request has been merged in d0015e0. |
Collaborator
|
This pull request was successfully merged by @jorge-cab in d0015e0 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Before we were adding a single pixel for the stretchable area. in RCTViewComponentView we calculate what percentage is 1 pixel from the entire image to create the unit rectangle:
However sometimes when dividing
1.0 / imageSize.widthwe would get a big enough float that causes a rounding error essentially having part of the border bleed into the stretchable region.The easiest way to fix this is give the stretchable region a little more space so to prevent the bleeding.
We can do this by just making the border image's width and height into integers by rounding the edgeInsets.
The alternative is some shockingly complex math to appropriately calculate the most convenient stretchable area size
Differential Revision: D85260693