pass down isAsync arg to start/stopOnRenderCallback to indicate thread#54252
Closed
zeyap wants to merge 1 commit into
Closed
pass down isAsync arg to start/stopOnRenderCallback to indicate thread#54252zeyap wants to merge 1 commit into
zeyap wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
zeyap
force-pushed
the
export-D85365058
branch
5 times, most recently
from
febde23 to
8e33d6f
Compare
#54252) Summary: ## Changelog: [Internal] [Added] - pass down isAsync arg to start/stopOnRenderCallback to indicate thread make it more explicit where start/stopOnRenderCallback is invoked so we can handle it on each platform in a more thread safe way Reviewed By: lenaic Differential Revision: D85365058
zeyap
force-pushed
the
export-D85365058
branch
from
8e33d6f to
2948ec2
Compare
|
This pull request has been merged in 43f464b. |
Collaborator
|
This pull request was successfully merged by @zeyap in 43f464b When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] [Added] - pass down isAsync arg to start/stopOnRenderCallback to indicate thread
make it more explicit where start/stopOnRenderCallback is invoked so we can handle it on each platform in a more thread safe way
Differential Revision: D85365058