Add selection to TextInput onChange event (native)#55044
Closed
alanleedev wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@alanleedev has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90123295. |
alanleedev
force-pushed
the
export-D90123295
branch
from
6a99b0c to
4fc7fac
Compare
alanleedev
force-pushed
the
export-D90123295
branch
from
4fc7fac to
92548cd
Compare
Summary: This change adds `selection` data to the `TextInput.onChange` event for both iOS and Android platforms. NOTE: `selection` only represents the cursor location when returned via `onChange` as this will not be invoked on a pure selection change without text change. We should also add this note to the documentation. ## Why On the web, text input elements provide `selectionStart` and `selectionEnd` properties that are always accessible during input events. React Native's `onChange` event previously included `selection` on iOS (Fabric), but this was removed in PR [react#51051](react#51051) to unify with Android (which never had it). This change restores and extends this capability to both platforms, better aligning React Native with web standards. This is also to support pollyfill added in `react-strict-dom`; react/react-strict-dom#435 ## What Changed 1. **iOS/macOS (C++)**: Enable selection in `onChange` event via `TextInputEventEmitter` 2. **Android (Kotlin)**: Added selection data to `ReactTextChangedEvent` Changelog: [General][Added] - TextInput onChange event now includes selection data (cursor location) on iOS and Android Reviewed By: cipolleschi, javache Differential Revision: D90123295
alanleedev
force-pushed
the
export-D90123295
branch
from
92548cd to
d5e7b02
Compare
|
This pull request has been merged in 162627a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds
selectiondata to theTextInput.onChangeevent for both iOS and Android platforms.NOTE:
selectiononly represents the cursor location when returned viaonChangeas this will not be invoked on a pure selection change without text change. We should also add this note to the documentation.Why
On the web, text input elements provide
selectionStartandselectionEndproperties that are always accessible during input events.React Native's
onChangeevent previously includedselectionon iOS (Fabric), but this was removed in PR #51051 to unify with Android (which never had it). This change restores and extends this capability to both platforms, better aligning React Native with web standards.This is also to support pollyfill added in
react-strict-dom; react/react-strict-dom#435What Changed
onChangeevent viaTextInputEventEmitterReactTextChangedEventChangelog
[General][Added] - TextInput onChange event now includes selection data (cursor location) on iOS and Android
Differential Revision: D90123295