Fix unused parameter warning in propsConversions.h (#56500)#56500
Closed
christophpurrer wants to merge 1 commit into
Closed
Fix unused parameter warning in propsConversions.h (#56500)#56500christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101111638. |
Summary: Fixed clang-diagnostic-unused-parameter warning in React Native's propsConversions.h by commenting out the unused `context` parameter in the `fromRawValue` template function. This change maintains API compatibility while resolving the compiler warning. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D101111638
meta-codesync
Bot
changed the title
christophpurrer
force-pushed
the
export-D101111638
branch
from
9ccaaed to
6e6038e
Compare
Collaborator
|
This pull request was successfully merged by @christophpurrer in d655114 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in d655114. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed clang-diagnostic-unused-parameter warning in React Native's propsConversions.h by commenting out the unused
contextparameter in thefromRawValuetemplate function.This change maintains API compatibility while resolving the compiler warning.
Changelog: [Internal]
Reviewed By: NickGerleman
Differential Revision: D101111638