Skip to content

Fix -Wnullable-to-nonnull-conversion for Xcode 26.4 (#56518) #56518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fkgozali wants to merge 1 commit into from
Closed

Fix -Wnullable-to-nonnull-conversion for Xcode 26.4 (#56518) #56518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...r/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTTextLayoutManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,8 @@ - (LinesMeasurements)getLinesForAttributedString:(facebook::react::AttributedStr

CGFloat baseline = [layoutManager locationForGlyphAtIndex:range.location].y;
auto line = LineMeasurement{
std::string([renderedString UTF8String]),
std::string(
[renderedString UTF8String] != nullptr ? [renderedString UTF8String] : ""),
rect,
overallRect.size.height - baseline,
font.capHeight,
Expand Down
6 changes: 4 additions & 2 deletions packages/rn-tester/NativeComponentExample/ios/RNTMyNativeViewCommon.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ @implementation UIView (ColorOverlays)

- (void)setBackgroundColorWithColorString:(NSString *)colorString
{
UIColor *color = [UIView UIColorFromHexString:std::string([colorString UTF8String])];
const char *colorUTF8 = [colorString UTF8String];
UIColor *color = [UIView UIColorFromHexString:std::string(colorUTF8 != nullptr ? colorUTF8 : "")];
self.backgroundColor = color;
}

Expand All @@ -23,7 +24,8 @@ - (void)addColorOverlays:(const NSArray *)overlayColors
id colorString = [overlayColors objectAtIndex:i];
CGRect rect = CGRectMake(viewBounds.origin.x + width * i, viewBounds.origin.y, width, viewBounds.size.height);
UIView *overlayView = [[UIView alloc] initWithFrame:rect];
UIColor *color = [UIView UIColorFromHexString:std::string([colorString UTF8String])];
const char *colorUTF8 = [colorString UTF8String];
UIColor *color = [UIView UIColorFromHexString:std::string(colorUTF8 != nullptr ? colorUTF8 : "")];
overlayView.backgroundColor = color;
[self addSubview:overlayView];
}
Expand Down
Loading