Skip to content

Build both coverage and non-coverage tester binaries in CI #56538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubennorte wants to merge 1 commit into from
Closed

Build both coverage and non-coverage tester binaries in CI #56538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions private/react-native-fantom/runner/global-setup/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,25 @@ export default async function build(
fs.mkdirSync(NATIVE_BUILD_OUTPUT_PATH, {recursive: true});

if (isCI) {
// When `enableCoverage` is true (CI coverage runs), we still need the
// non-coverage tester binaries because some tests opt out of coverage
// (benchmarks via filename, or tests with the `@fantom_disable_coverage`
// pragma — see `runner/coverageUtils.js`). Without these, those tests
// would fail to spawn with ENOENT.
const coverageVariants = enableCoverage ? [false, true] : [false];

for (const enableOptimized of [false, true]) {
for (const hermesVariant of HermesVariant.members()) {
buildFantomTester(
{enableOptimized, hermesVariant, enableCoverage},
env,
);
for (const variantEnableCoverage of coverageVariants) {
buildFantomTester(
{
enableOptimized,
hermesVariant,
enableCoverage: variantEnableCoverage,
},
env,
);
}
buildHermesCompiler({enableOptimized, hermesVariant, enableCoverage});
}
}
Expand Down
Loading