Reorganize unit and benchmark tests#424
Merged
Merged
Conversation
* Break up large test files into smaller test files for each API * Do not use 'css.props' (implementation detail) in unit tests
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
This native benchmark is being removed for the following reasons: * It doesn't run on Hermes, so is only a proxy for React Native perf * It has been replaced by e2e React Native tests (Fantom) internally * The API itself doesn't exist on web and the plan is to remove it from native
62ceaf7 to
1f2414f
Compare
workflow: benchmarks/perf (native)Comparison of performance test results, measured in operations per second. Larger is better.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of these changes is to make it easier to navigate and update unit tests, while reducing the reliance on implementation details (and test-only abstractions) in tests
Refactor unit tests
Remove css.props benchmark