Run tests on PHP 8.4 and update test environment + PCOV to avoid segfault with Xdebug 3.4.2 #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
requested changes
Jul 21, 2025
Comment on lines
+81
to
+94
| - name: Install ev extension (PHP < 8.0) | ||
| if: ${{ matrix.php < '8.0' }} | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y libev-dev | ||
| sudo pecl install ev-1.1.5 | ||
| echo "extension=ev.so" | sudo tee -a "$(php -r 'echo php_ini_loaded_file();')" | ||
| - name: Install ev extension (PHP >= 8.0) | ||
| if: ${{ matrix.php >= '8.0' }} | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y libev-dev | ||
| sudo pecl install ev | ||
| echo "extension=ev.so" | sudo tee -a "$(php -r 'echo php_ini_loaded_file();')" |
There was a problem hiding this comment.
I don't think this should be added here for the "unstable" environment, as it's already tested above.
Suggested change
| - name: Install ev extension (PHP < 8.0) | |
| if: ${{ matrix.php < '8.0' }} | |
| run: | | |
| sudo apt-get update | |
| sudo apt-get install -y libev-dev | |
| sudo pecl install ev-1.1.5 | |
| echo "extension=ev.so" | sudo tee -a "$(php -r 'echo php_ini_loaded_file();')" | |
| - name: Install ev extension (PHP >= 8.0) | |
| if: ${{ matrix.php >= '8.0' }} | |
| run: | | |
| sudo apt-get update | |
| sudo apt-get install -y libev-dev | |
| sudo pecl install ev | |
| echo "extension=ev.so" | sudo tee -a "$(php -r 'echo php_ini_loaded_file();')" |
Comment on lines
-31
to
-32
| env: | ||
| fail-fast: true # fail step if any extension can not be installed |
There was a problem hiding this comment.
I don't think this should be removed?
Comment on lines
+32
to
+45
| - name: Install ev extension (PHP < 8.0) | ||
| if: ${{ matrix.php < '8.0' }} | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y libev-dev | ||
| sudo pecl install ev-1.1.5 | ||
| echo "extension=ev.so" | sudo tee -a "$(php -r 'echo php_ini_loaded_file();')" | ||
| - name: Install ev extension (PHP >= 8.0) | ||
| if: ${{ matrix.php >= '8.0' }} | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y libev-dev | ||
| sudo pecl install ev | ||
| echo "extension=ev.so" | sudo tee -a "$(php -r 'echo php_ini_loaded_file();')" |
There was a problem hiding this comment.
This looks like AI slop. This adds a fair bit of redundant code that can be avoided (see above).
| extensions: sockets, pcntl, event, ev | ||
| env: | ||
| fail-fast: true # fail step if any extension can not be installed | ||
| extensions: sockets, pcntl, event |
There was a problem hiding this comment.
The motivation is unclear and I'm not sure why ev was removed here exactly, but the code below makes it looks like we perhaps want to use a ternary to select different versions similar to #270?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #269, #270 and reactphp/socket#323.
Also had to remove ext-ev from default extensions, install it explicitly based on PHP version.