[code-quality] Add InlineClassRoutePrefixRector (#701)

Author: TomasVotruba

config/sets/symfony/symfony-code-quality.php

@@ -5,6 +5,7 @@
 use Rector\Config\RectorConfig;
 use Rector\Symfony\CodeQuality\Rector\BinaryOp\ResponseStatusCodeRector;
 use Rector\Symfony\CodeQuality\Rector\Class_\EventListenerToEventSubscriberRector;
+use Rector\Symfony\CodeQuality\Rector\Class_\InlineClassRoutePrefixRector;
 use Rector\Symfony\CodeQuality\Rector\Class_\LoadValidatorMetadataToAnnotationRector;
 use Rector\Symfony\CodeQuality\Rector\ClassMethod\ActionSuffixRemoverRector;
 use Rector\Symfony\CodeQuality\Rector\ClassMethod\ParamTypeFromRouteRequiredRegexRector;
@@ -30,5 +31,8 @@
 
         // tests
         AssertSameResponseCodeWithDebugContentsRector::class,
+
+        // routing
+        InlineClassRoutePrefixRector::class,
     ]);
 };

rules-tests/CodeQuality/Rector/Class_/InlineClassRoutePrefixRector/Fixture/explicit_silent_mix.php.inc

@@ -0,0 +1,40 @@
+<?php
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\InlineClassRoutePrefixRector\Fixture;
+
+use Symfony\Bundle\FrameworkBundle\Controller\Controller;
+use Symfony\Component\Routing\Annotation\Route;
+
+/**
+ * @Route(path="/city")
+ */
+final class ExplicitSilentMix extends Controller
+{
+    /**
+     * @Route("/street")
+     */
+    public function some()
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\InlineClassRoutePrefixRector\Fixture;
+
+use Symfony\Bundle\FrameworkBundle\Controller\Controller;
+use Symfony\Component\Routing\Annotation\Route;
+
+final class ExplicitSilentMix extends Controller
+{
+    /**
+     * @Route("/city/street")
+     */
+    public function some()
+    {
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/Class_/InlineClassRoutePrefixRector/Fixture/inversed_explicit_silent_mix.php.inc

@@ -0,0 +1,40 @@
+<?php
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\InlineClassRoutePrefixRector\Fixture;
+
+use Symfony\Bundle\FrameworkBundle\Controller\Controller;
+use Symfony\Component\Routing\Annotation\Route;
+
+/**
+ * @Route("/city")
+ */
+final class InversedExplicitSilentMix extends Controller
+{
+    /**
+     * @Route(path="/street")
+     */
+    public function some()
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\InlineClassRoutePrefixRector\Fixture;
+
+use Symfony\Bundle\FrameworkBundle\Controller\Controller;
+use Symfony\Component\Routing\Annotation\Route;
+
+final class InversedExplicitSilentMix extends Controller
+{
+    /**
+     * @Route(path="/city/street")
+     */
+    public function some()
+    {
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/Class_/InlineClassRoutePrefixRector/Fixture/skip_no_controller.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\InlineClassRoutePrefixRector\Fixture;
+
+use Symfony\Component\Routing\Annotation\Route;
+
+/**
+ * @Route("/city")
+ */
+final class SkipNoController
+{
+    /**
+     * @Route("/street")
+     */
+    public function some()
+    {
+    }
+}

rules-tests/CodeQuality/Rector/Class_/InlineClassRoutePrefixRector/Fixture/some_routing_class.php.inc

@@ -0,0 +1,40 @@
+<?php
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\InlineClassRoutePrefixRector\Fixture;
+
+use Symfony\Bundle\FrameworkBundle\Controller\Controller;
+use Symfony\Component\Routing\Annotation\Route;
+
+/**
+ * @Route("/city")
+ */
+final class SomeRoutingClass extends Controller
+{
+    /**
+     * @Route("/street")
+     */
+    public function some()
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\InlineClassRoutePrefixRector\Fixture;
+
+use Symfony\Bundle\FrameworkBundle\Controller\Controller;
+use Symfony\Component\Routing\Annotation\Route;
+
+final class SomeRoutingClass extends Controller
+{
+    /**
+     * @Route("/city/street")
+     */
+    public function some()
+    {
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/Class_/InlineClassRoutePrefixRector/InlineClassRoutePrefixRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\InlineClassRoutePrefixRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class InlineClassRoutePrefixRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/CodeQuality/Rector/Class_/InlineClassRoutePrefixRector/config/configured_rule.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Symfony\CodeQuality\Rector\Class_\InlineClassRoutePrefixRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(InlineClassRoutePrefixRector::class);
+};