Skip to content

[CodeQuality] Add AddTraitGetterReturnTypeBasedOnSetterRequiredRector #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 3, 2024
Merged

[CodeQuality] Add AddTraitGetterReturnTypeBasedOnSetterRequiredRector #671

merged 5 commits into from
Oct 3, 2024

Conversation

samsonasik
Copy link
Member

@TomasVotruba here the rule for our project for add getter return type by @required in settter in trait.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

Thanks 👍

Could you add support for #[\Symfony\Contracts\Service\Attribute\Required] PHP 8 attribute as well?

@samsonasik
Copy link
Member Author

sure, I added Required attribute support 93f3b6c

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba
Copy link
Member

Looks good, thank you 👍

@TomasVotruba TomasVotruba merged commit 928f117 into main Oct 3, 2024
5 checks passed
@TomasVotruba TomasVotruba deleted the add-trait branch October 3, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @TomasVotruba