[Symfony 7.3] add constant and test for 7.3 and test help to attribute #718

[JohJohan]

From: #718

Thanks for the report. Rule is in very early stages, based on couple diffs of referenced PR, so any test fixture of the right setup will help.

Can you send a PR with the test fixture you expect?

We would need:

1. Set support for symfony/console to 7.3 or at least define AsCommand has attribute help
2. Write a rector rule who will move help to the attribute (and make sure this is done before InvokableCommandRector as that will remove configure in total.

[TomasVotruba]

Awesome, thanks for the test fixture 👍

Could you add fix as well?

[TomasVotruba]

Looks good 👍

[JohJohan]

@samsonasik note i did:

1. Added fixture to call all for CommandConfigureToAttributeRector (to check that the output will work for CommandHelpToAttributeRector and InvokableCommandRector
2. For InvokableCommandRector i made sure we also cleanup method chaining calls (also a fixture for this)
3. For CommandConfigureToAttributeRector added a fixture that has all attributes set from example CommandConfigureToAttributeRector rule and will add help attribute

[samsonasik]

Let's give it a try, thank you @JohJohan

[TomasVotruba]

Thakn you @JohJohan 👏