Skip to content

fix to type arg name #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

fix to type arg name #800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../JMS/Rector/Class_/AccessTypeAnnotationToAttributeRector/Fixture/annotation_types.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ namespace Rector\Symfony\Tests\JMS\Rector\Class_\AccessTypeAnnotationToAttribute

use JMS\Serializer\Annotation as Serializer;

#[Serializer\AccessType(values: ['public_method'])]
#[Serializer\AccessType(type: 'public_method')]
final class AnnotationTypes
{
public function run(): void
Expand Down
6 changes: 1 addition & 5 deletions rules/JMS/Rector/Class_/AccessTypeAnnotationToAttributeRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
namespace Rector\Symfony\JMS\Rector\Class_;

use PhpParser\Node;
use PhpParser\Node\ArrayItem;
use PhpParser\Node\AttributeGroup;
use PhpParser\Node\Expr\Array_;
use PhpParser\Node\Identifier;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\Property;
Expand Down Expand Up @@ -81,9 +79,7 @@ public function refactor(Node $node): Class_|Property|null

if (count($attribute->args) === 1) {
$soleArg = $attribute->args[0];
// wrap to array
$soleArg->name = new Identifier('values');
$soleArg->value = new Array_([new ArrayItem($soleArg->value)]);
$soleArg->name = new Identifier('type');
}

// 2. Reprint docblock
Expand Down