Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
use PhpParser\Node\Stmt\ClassMethod;
use PHPStan\Type\ObjectType;
use Rector\Rector\AbstractRector;
use Rector\Symfony\Enum\SymfonyClass;
use Rector\Symfony\NodeAnalyzer\ClassAnalyzer;
use Rector\Symfony\NodeFactory\GetSubscribedEventsClassMethodFactory;
use Rector\Symfony\NodeFactory\OnSuccessLogoutClassMethodFactory;
Expand All @@ -31,9 +32,7 @@ public function __construct(
private readonly GetSubscribedEventsClassMethodFactory $getSubscribedEventsClassMethodFactory,
private readonly ClassAnalyzer $classAnalyzer,
) {
$this->successHandlerObjectType = new ObjectType(
'Symfony\Component\Security\Http\Logout\LogoutSuccessHandlerInterface'
);
$this->successHandlerObjectType = new ObjectType(SymfonyClass::LOGOUT_SUCCESS_HANDLER);
}

public function getRuleDefinition(): RuleDefinition
Expand Down Expand Up @@ -120,16 +119,13 @@ public function refactor(Node $node): ?Node
return null;
}

if (! $this->classAnalyzer->hasImplements(
$node,
'Symfony\Component\Security\Http\Logout\LogoutSuccessHandlerInterface'
)) {
if (! $this->classAnalyzer->hasImplements($node, SymfonyClass::LOGOUT_SUCCESS_HANDLER)) {
return null;
}

$this->refactorImplements($node);

$node->implements[] = new FullyQualified('Symfony\Component\EventDispatcher\EventSubscriberInterface');
$node->implements[] = new FullyQualified(SymfonyClass::EVENT_SUBSCRIBER_INTERFACE);

// 2. refactor logout() class method to onLogout()
$onLogoutSuccessClassMethod = null;
Expand Down
5 changes: 5 additions & 0 deletions src/Enum/SymfonyClass.php
Original file line number Diff line number Diff line change
Expand Up @@ -145,4 +145,9 @@ final class SymfonyClass
* @var string
*/
public const SYMFONY_STYLE = 'Symfony\Component\Console\Style\SymfonyStyle';

/**
* @var string
*/
public const LOGOUT_SUCCESS_HANDLER = 'Symfony\Component\Security\Http\Logout\LogoutSuccessHandlerInterface';
}