Enable ArgoCD Progressive Sync feature #151
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ammachado is progressive sync turned on for "new" argo instances these days? If it is, I would say let's keep it in the base. If not, maybe we configure it as a component. That would make it easier for people to choose to use it or not in the future. |
|
No, @strangiato, progressive syncs is still an "alpha" feature, so its not enabled by default on ArgoCD, but usage is opt-in, requiring explicit configuration on the So, should I move it to a different component? |
|
Yeah, let's make it a component so it is easy to disable if a user wants to |
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
ammachado
force-pushed
the
argocd-progressive-sync
branch
from
83cc36a to
7a77bb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables ArgoCD's Progressive Syncs feature on the Openshift GitOps operator.
This feature enables basic application deployment ordering by the ArgoCD controller, when specified.
Checklist
Test Plan
Deploy the AI Accelerator to an Openshift cluster and then check if the
openshift-gitopsArgoCDinstance has the parameter added:$ oc get argocd/openshift-gitops -n openshift-gitops -o jsonpath='{.spec.applicationSet.extraArguments[0]}' --enable-progressive-syncsThere is no changes on ArgoCD's UI or current application deployment.
Documentation