Skip to content

adding increase / decrease functions #103

Open
RawanAbuleil wants to merge 1 commit intoredhat-beyond:mainfrom
RawanAbuleil:functions
Open

adding increase / decrease functions #103
RawanAbuleil wants to merge 1 commit intoredhat-beyond:mainfrom
RawanAbuleil:functions

Conversation

@RawanAbuleil
Copy link
Contributor

@RawanAbuleil RawanAbuleil commented Jan 17, 2023 •
edited
Loading

****This PR is based on PR no. 91 , once it's merged will update

  1. two view functions created :

    • increase quantity : which increases the product quantity by one when pressing on the + button from the supplier html page
    • decrease quantity: lowers the products quantity by one when pressing on the + button from the supplier html page

  2. one test has been created for each function .

  3. added two buttons to the supplier html file
    closed create increase / decrease functions  #104

thetaxas2468
thetaxas2468 reviewed Jan 17, 2023
View reviewed changes
supplier_product/views.py Outdated


def increase_quantity(request, id):
SupplierProduct.objects.filter(supplier_product_id=id).update(quantity=F('quantity')+1)
Copy link
Collaborator

@thetaxas2468 thetaxas2468 Jan 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you use this since you have increase method in the supplierproduct

supplier_product/views.py Outdated
def decrease_quantity(request, id):
product = SupplierProduct.objects.get(supplier_product_id=id)
if product.quantity > 0:
SupplierProduct.objects.filter(supplier_product_id=id).update(quantity=F('quantity')-1)
Copy link
Collaborator

@thetaxas2468 thetaxas2468 Jan 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as increasing

@thetaxas2468
Copy link
Collaborator

thetaxas2468 commented Jan 17, 2023

  • Please squash extra commits like 1
  • Add images about the progress if you can

@pazMenachem
Copy link
Collaborator

pazMenachem commented Jan 17, 2023 •
edited
Loading

@thetaxas2468
spot on with the comments, was thinking the same
thou, i will add that you could have rebased on my PR instead of copying the code.

Why would you use create method since there is save product method that is created
fixture from conftest.
no need to import it also, since its in the project file.

do tell if any help is needed.

@RawanAbuleil RawanAbuleil force-pushed the functions branch 2 times, most recently from a984014 to 97677e5 Compare January 19, 2023 12:13
@thetaxas2468
Copy link
Collaborator

thetaxas2468 commented Jan 19, 2023

  • Squash your commits 1 and last one and rebase on upstream/main since your first commit is merged
  • increase and decrease functions is on views but where do we use them in the front

@thetaxas2468 thetaxas2468 added the Ready for review PR is following the contribution guide and has the whole functionality and tests ready. label Jan 19, 2023
@Omeramsc
Copy link
Contributor

Omeramsc commented Jan 19, 2023

91 is merged, please rebase on top of main and possibly squash the commits, it'll make it much easier to review. I believe we would be able to merge it today as Karam provided a lot of good feedback.

@yftacherzog @RawanAbuleil
Merge pull request redhat-beyond#95 from LiorSilberman/supplier_deli
e2352f2 
Creating increase / decrease quantity views functions :
** this code depends on suppliers.html code which hasn't been merged yes once the code is merged i will change it **
two functions has been created : which increase and decrease the quantity of a product by it's supplier
 *** modifie the code so it increase / decrease the quantity by "n" not one
 *** no changes in the suppliers html file.
@thetaxas2468
Copy link
Collaborator

thetaxas2468 commented Jan 19, 2023

You have the same problem as lior had in his closed PR about linkedin,check it out(the problem is about your commit maybe you have done commit --amend at the start or you have squashed your commit with the merged commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pazMenachem pazMenachem Awaiting requested review from pazMenachem

@LiorSilberman LiorSilberman Awaiting requested review from LiorSilberman

@MeitarRizner MeitarRizner Awaiting requested review from MeitarRizner

@Omeramsc Omeramsc Awaiting requested review from Omeramsc

@yftacherzog yftacherzog Awaiting requested review from yftacherzog

@nofaralfasi nofaralfasi Awaiting requested review from nofaralfasi

@brochwerger brochwerger Awaiting requested review from brochwerger

1 more reviewer

@thetaxas2468 thetaxas2468 thetaxas2468 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@RawanAbuleil RawanAbuleil

Labels

Ready for review PR is following the contribution guide and has the whole functionality and tests ready.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

create increase / decrease functions

5 participants

@RawanAbuleil @thetaxas2468 @pazMenachem @Omeramsc @yftacherzog