Backstage templates #127
Backstage templates #127
Conversation
Signed-off-by: Justin Cinkelj <[email protected]>
justinc1
force-pushed
the
backstage-templates
branch
from
9a6a7bf to
852838b
Compare
|
Just tested this, both create and terminate patterns work. I see linter fixes are needed. |
This reverts commit ba81f54.
hakbailey
left a comment
hakbailey
left a comment
There was a problem hiding this comment.
Is there a dev environment where we can test this?
extensions/patterns/configure_ec2/template_rhdh/create_ec2_instance.yml
Outdated
Show resolved
Hide resolved
| description: AWS region where resources should be created | ||
| type: string | ||
| ui:options: | ||
| rows: 5 |
There was a problem hiding this comment.
I'm not super familiar with how the backstage templates work, what does rows: 5 do?
There was a problem hiding this comment.
https://backstage.io/docs/features/software-templates/writing-templates/
This rows: 5 is in all samples.
extensions/patterns/configure_ec2/template_rhdh/terminate_ec2_instance.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: Justin Cinkelj <[email protected]>
Signed-off-by: Justin Cinkelj <[email protected]>
| type: string | ||
| ui:options: | ||
| rows: 5 | ||
| sg_rules: |
There was a problem hiding this comment.
One thing we should double check, because I didn't see it tested in the demo video, is that this field correctly handles multiline yaml text, e.g.:
- proto: tcp
ports: 80
cidr_ip: 0.0.0.0/0
I've verified this works when running the job from AAP, I just want to make sure it also works as expected when launching the job template from RHDH.
There was a problem hiding this comment.
I tested, with port 80, 8080, 22 in the list. Part of AAP job output:
TASK [Get security group rules list from string input] *************************
ok: [localhost] => {"ansible_facts": {"sg_rules_list": [{"cidr_ip": "0.0.0.0/0", "ports": 80, "proto": "tcp"}, {"cidr_ip": "0.0.0.0/0", "ports": 8080, "proto": "tcp"}, {"cidr_ip": "0.0.0.0/0", "ports": 22, "proto": "tcp"}]}, "changed": false}
It works
extensions/patterns/configure_ec2/template_rhdh/create_ec2_instance.yml
Outdated
Show resolved
Hide resolved
extensions/patterns/configure_ec2/template_rhdh/terminate_ec2_instance.yml
Show resolved
Hide resolved
…tance.yml Co-authored-by: Helen Bailey <[email protected]>
GomathiselviS
dismissed
hakbailey’s stale review
Dismissing as the functionality has been tested justinc1
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #137 🤖 @patchback |
Backstage templates (cherry picked from commit de22d7f)
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #143 🤖 @patchback |
Backstage templates (cherry picked from commit de22d7f)
…de22d7f65674340e533a346c4631d8254724c9bc/pr-127 [PR #127/de22d7f6 backport][stable-3] Backstage templates
5 participants
Add backstage templates