Small updates to ec2 pattern#130
Merged
hakbailey merged 2 commits intoredhat-cop:mainfrom Dec 13, 2024
Merged
Conversation
gravesm
approved these changes
Dec 13, 2024
GomathiselviS
approved these changes
Dec 13, 2024
Backport to stable-3: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 1c2b0e9 on top of patchback/backports/stable-3/1c2b0e9ffaa7eacc783dc790ec822e258fcbd28e/pr-130 Backporting merged PR #130 into main
🤖 @patchback |
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #146 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
Small updates to ec2 pattern (cherry picked from commit 1c2b0e9)
abikouo
added a commit
that referenced
this pull request
Jan 27, 2025
…1c2b0e9ffaa7eacc783dc790ec822e258fcbd28e/pr-130 [PR #130/1c2b0e9f backport][stable-3] Small updates to ec2 pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two updates:
key_info_resultin the pattern playbook, because it gets overwritten by the included role playbook.ec2_key_infooutput because that doesn't include the private key, and if there's an error with the key (for example if the user was expecting the key to be present) it's helpful to be able to see what the returned value was.