Skip to content

Conversation

@akira6592
Copy link
Contributor

@akira6592 akira6592 commented Dec 14, 2024

What does this PR do?

Now the repo url https://github.com/redhat-cop/controller_configuration is redirected to https://github.com/redhat-cop/infra.aap_configuration.

So I fixed the repo url of infra.controller_configuration to https://github.com/redhat-cop/infra.controller_configuration in docs.

How should this be tested?

Is there a relevant Issue open for this?

Other Relevant info, PRs, etc

@akira6592 akira6592 requested a review from a team as a code owner December 14, 2024 00:52
@akira6592 akira6592 changed the title Fix repo url galaxy Fix repo url Dec 14, 2024
galaxy.yml Outdated
repository: https://github.com/redhat-cop/controller_configuration/
issues: https://github.com/redhat-cop/controller_configuration//issues
repository: https://github.com/redhat-cop/infra.controller_configuration/
issues: https://github.com/redhat-cop/infra.controller_configuration//issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like a double slash at some point got put in here, while you are at it could you fix that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djdanielsson Thank you for reviewing. I fixed it.

@sean-m-sullivan
Copy link
Contributor

Needs updated links are broken, and other pieces need to be fixed

@akira6592
Copy link
Contributor Author

@sean-m-sullivan Do you think should I fix other links by this PR?

e.g.

[GPL-3.0](https://github.com/redhat-cop/controller_configuration#licensing)

Copy link
Contributor

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdanielsson djdanielsson merged commit 59aa6f2 into redhat-cop:devel Dec 14, 2024
6 of 13 checks passed
@djdanielsson
Copy link
Contributor

Oops didn't see the comments until after I hit merge cuz I saw the change I had wanted was done

@akira6592
Copy link
Contributor Author

akira6592 commented Dec 15, 2024

If it needed, I will fix other links by an other PR.

ivarmu pushed a commit that referenced this pull request Mar 18, 2025
* feat: allow export only inventory

* fix: missing dashes

* fix: remove the blocks

* feat: allow to customize exported JT

* feat: allow to customize exported WF

* feat: allow to customize exported schedule

* feat: allow to customize exported project

* feat: allow to customize exported team description

* feat: allow to customize exported user details

* feat: allow to customize exported organization description

* feat: allow to customize exported inventory source

* feat: allow to customize exported inventory

* feat: allow to customize exported hosts

* feat: allow to customize exported groups

* feat: allow to customize exported execution environemnts

* feat: allow to customize exported credentials

* feat: allow to customize exported credential types

* feat: allow to customize exported applications

* misc: documentation related to feature

* fix: indentation

* misc: example of usage new dictionaries, modify name of dicts to proper

* fix: missing/overlooked code

* Update roles/filetree_create/README.md

* fix: remove blank space

* misc: remove global option for credential

* fix: missing description override from resources, typo

---------

Co-authored-by: Przemyslaw Kalitowski <[email protected]>
Co-authored-by: Tom Page <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants