-
Notifications
You must be signed in to change notification settings - Fork 61
fix: ensure removed kernel modules are not loaded at boot; add module remediation test #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[citest] |
5 similar comments
|
[citest] |
|
[citest] |
|
[citest] |
|
[citest] |
|
[citest] |
bee7896 to
d4c610b
Compare
|
[citest] |
2 similar comments
|
[citest] |
|
[citest] |
dde7808 to
6e2c0e2
Compare
|
@swapdisk I don't know if we have changed something since we have been working on the role, but now during some cases the node is rebooted after analysis and before upgrade, and this causes kernel modules to be reloaded, even if they have been unloaded with the |
|
[citest] |
|
tests are failing because the |
6e2c0e2 to
d97f002
Compare
|
[citest] |
|
It doesn't like |
d97f002 to
3d5bede
Compare
|
[citest] |
spetrosi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm except for one question
3d5bede to
3211055
Compare
… remediation test Ensure that removed/unloaded kernel modules are not reloaded at boot. It seems that the upgrade run can reboot the system after analysis but before upgrade, and if the unsupported kernel modules are not disabled, they will be loaded again at boot. I have also added a test for the unsupported kernel module remediation. This also refactors the kernel module load/unload code into a new common tasks file manage_kernel_modules.yml which implements the modprobe plus the module file handling. Signed-off-by: Rich Megginson <[email protected]>
3211055 to
d4dfbb8
Compare
|
[citest] |
|
if no further comments, please merge |
Ensure that removed/unloaded kernel modules are not reloaded at boot. It seems that
the upgrade run can reboot the system after analysis but before upgrade, and if the
unsupported kernel modules are not disabled, they will be loaded again at boot.
I have also added a test for the unsupported kernel module remediation.
This also refactors the kernel module load/unload code into a new common
tasks file manage_kernel_modules.yml which implements the modprobe plus the
module file handling.