Skip to content

Conversation

@richm
Copy link
Collaborator

@richm richm commented Dec 17, 2025

Ensure that removed/unloaded kernel modules are not reloaded at boot. It seems that
the upgrade run can reboot the system after analysis but before upgrade, and if the
unsupported kernel modules are not disabled, they will be loaded again at boot.

I have also added a test for the unsupported kernel module remediation.

This also refactors the kernel module load/unload code into a new common
tasks file manage_kernel_modules.yml which implements the modprobe plus the
module file handling.

@richm richm marked this pull request as draft December 17, 2025 17:45
@richm
Copy link
Collaborator Author

richm commented Dec 17, 2025

[citest]

5 similar comments
@richm
Copy link
Collaborator Author

richm commented Dec 17, 2025

[citest]

@richm
Copy link
Collaborator Author

richm commented Dec 17, 2025

[citest]

@richm
Copy link
Collaborator Author

richm commented Dec 17, 2025

[citest]

@richm
Copy link
Collaborator Author

richm commented Dec 17, 2025

[citest]

@richm
Copy link
Collaborator Author

richm commented Dec 18, 2025

[citest]

@richm richm force-pushed the debug-ci-failures branch from bee7896 to d4c610b Compare December 18, 2025 15:49
@richm
Copy link
Collaborator Author

richm commented Dec 18, 2025

[citest]

2 similar comments
@richm
Copy link
Collaborator Author

richm commented Dec 18, 2025

[citest]

@richm
Copy link
Collaborator Author

richm commented Dec 18, 2025

[citest]

@richm richm changed the title ci: debug test failures fix: ensure removed kernel modules are not loaded at boot; add module remediation test Dec 18, 2025
@richm richm force-pushed the debug-ci-failures branch 3 times, most recently from dde7808 to 6e2c0e2 Compare December 19, 2025 00:02
@richm
Copy link
Collaborator Author

richm commented Dec 19, 2025

@swapdisk I don't know if we have changed something since we have been working on the role, but now during some cases the node is rebooted after analysis and before upgrade, and this causes kernel modules to be reloaded, even if they have been unloaded with the modprobe module, which causes upgrade to fail with inhibitors. I'm wondering why this ever worked? Note that the modprobe module, if you use persistent: absent, will manage the module-load and modprobe files, but only if they already exist. In this case, they do not.

@richm
Copy link
Collaborator Author

richm commented Dec 19, 2025

[citest]

@richm
Copy link
Collaborator Author

richm commented Dec 19, 2025

tests are failing because the pata_acpi module is not available on el8 or later. I have asked the leapp team for information about which modules are flagged as inhibitors that I can use for testing.

@richm richm force-pushed the debug-ci-failures branch from 6e2c0e2 to d97f002 Compare December 19, 2025 14:19
@richm
Copy link
Collaborator Author

richm commented Dec 19, 2025

[citest]

@richm
Copy link
Collaborator Author

richm commented Dec 19, 2025

It doesn't like floppy - need to revisit the list

@richm richm force-pushed the debug-ci-failures branch from d97f002 to 3d5bede Compare December 19, 2025 20:22
@richm richm marked this pull request as ready for review December 19, 2025 20:22
@richm
Copy link
Collaborator Author

richm commented Dec 19, 2025

[citest]

Copy link
Collaborator

@spetrosi spetrosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except for one question

@richm richm force-pushed the debug-ci-failures branch from 3d5bede to 3211055 Compare December 22, 2025 20:02
… remediation test

Ensure that removed/unloaded kernel modules are not reloaded at boot.  It seems that
the upgrade run can reboot the system after analysis but before upgrade, and if the
unsupported kernel modules are not disabled, they will be loaded again at boot.

I have also added a test for the unsupported kernel module remediation.

This also refactors the kernel module load/unload code into a new common
tasks file manage_kernel_modules.yml which implements the modprobe plus the
module file handling.

Signed-off-by: Rich Megginson <[email protected]>
@richm richm force-pushed the debug-ci-failures branch from 3211055 to d4dfbb8 Compare December 22, 2025 20:03
@richm
Copy link
Collaborator Author

richm commented Dec 22, 2025

[citest]

@richm
Copy link
Collaborator Author

richm commented Dec 22, 2025

if no further comments, please merge

@richm richm merged commit bc4c454 into redhat-cop:main Dec 23, 2025
25 checks passed
@richm richm deleted the debug-ci-failures branch December 23, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants