fix: remove timeout keyword for reboot - it is not correct #322
+3
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
[citest] |
There were several `reboot` modules using a `timeout` keyword. There is no such keyword - https://docs.ansible.com/projects/ansible/latest/reference_appendices/playbooks_keywords.html The `reboot` used in this collection already use the `reboot_timeout` and other timeout parameters - https://docs.ansible.com/projects/ansible/latest/collections/ansible/builtin/reboot_module.html It's possible that the `timeout` was left over from some very old version of Ansible. Fixes redhat-cop#321 Signed-off-by: Rich Megginson <[email protected]>
richm
force-pushed
the
fix-remove-timeout-keyword
branch
from
745cd9a to
0b6bf8f
Compare
spetrosi
reviewed
Jan 2, 2026
Collaborator
spetrosi
left a comment
spetrosi
left a comment
There was a problem hiding this comment.
Here timeout is a task keyword not specific to modules. So the syntax is correct.
https://docs.ansible.com/projects/ansible/latest/reference_appendices/playbooks_keywords.html#id5
Collaborator
Author
ok - I guess I missed that - the |
spetrosi
approved these changes
Jan 5, 2026
Collaborator
spetrosi
left a comment
spetrosi
left a comment
There was a problem hiding this comment.
Good point about Ansible 2.9. Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several
rebootmodules using atimeoutkeyword.There is no such keyword - https://docs.ansible.com/projects/ansible/latest/reference_appendices/playbooks_keywords.html
The
rebootused in this collection already use thereboot_timeoutandother timeout parameters - https://docs.ansible.com/projects/ansible/latest/collections/ansible/builtin/reboot_module.html
It's possible that the
timeoutwas left over from some very old version of Ansible.Fixes #321
Signed-off-by: Rich Megginson [email protected]