feat: add Helion setup script for modular installation#119
feat: add Helion setup script for modular installation#119cmagina wants to merge 5 commits intoredhat-et:mainfrom
Conversation
cmagina
force-pushed
the
pr-05-helion-setup-script
branch
from
b67144e to
9666738
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cmagina
force-pushed
the
pr-05-helion-setup-script
branch
3 times, most recently
from
b7adda5 to
15fd159
Compare
cmagina
force-pushed
the
pr-05-helion-setup-script
branch
2 times, most recently
from
3eb97ee to
3d64784
Compare
Add scripts/setup_helion.sh to support Helion installation and configuration within containers. This script: - Downloads Helion source from GitHub when not mounted as a volume - Installs build dependencies for Helion compilation - Supports installing Helion wheels from PyPI (release, nightly) - Provides flexible configuration via INSTALL_HELION environment variable The script supports multiple installation modes: - source: Build from source (with auto-download if not mounted) - release/nightly: Install wheels from PyPI - skip: Skip Helion installation This is part of the modular script architecture introduced in PR redhat-et#115. Signed-off-by: Craig Magina <cmagina@redhat.com>
cmagina
force-pushed
the
pr-05-helion-setup-script
branch
from
3d64784 to
1bcbbd4
Compare
scripts/devinstall_helion.sh
Outdated
|
|
||
| if [ -n "${PIP_HELION_INDEX_URL:-}" ]; then | ||
| echo "Using the specified index, $PIP_HELION_INDEX_URL" | ||
| PIP_INSTALL_ARGS+=("--index-url $PIP_HELION_INDEX_URL") |
There was a problem hiding this comment.
double space after --index-url
scripts/devinstall_helion.sh
Outdated
| popd 1>/dev/null | ||
| fi | ||
| else | ||
| echo "Torch repo already present, not cloning ..." |
There was a problem hiding this comment.
NIT: should be "helion"
scripts/devinstall_helion.sh
Outdated
| echo "Installing Helion dependencies ..." | ||
| pip_install numpy | ||
|
|
||
| devinstall_torch release |
There was a problem hiding this comment.
is this something we want to do unconditionally?
There was a problem hiding this comment.
That is a fair question, but if we don't then after running devinstall_helion release an attempt to run a helion program will fail with torch missing. Triton has a similar problem with torch not getting pulled in automatically when installing triton release.
There was a problem hiding this comment.
I think I have a solution, let me know what you think.
| - scripts/entrypoint.sh | ||
| - scripts/devinstall_software.sh | ||
| - scripts/ldpretend.sh | ||
| - scripts/devinstall_helion.sh |
There was a problem hiding this comment.
shouldn't helion build after triton since it's a dependency?
There was a problem hiding this comment.
That is just a list of files to watch for changes to trigger a github workflow, i.e. build the image.
- Removed double space - Corrected copy/paste error - Fixed installing torch no matter what as a dep - Re-ordered to after triton as triton is a dependency of helion Signed-off-by: Craig Magina <cmagina@redhat.com>
Signed-off-by: Craig Magina <cmagina@redhat.com>
Signed-off-by: Craig Magina <cmagina@redhat.com>
Signed-off-by: Craig Magina <cmagina@redhat.com>
2 participants
Summary
This PR is part 5 of 11 in the rework modernization effort. It adds the Helion setup script as part of the modular framework installation architecture.
Changes:
scripts/setup_helion.shfor Helion installation and configurationFeatures:
INSTALL_HELIONenvironment variable:source: Build from source (with auto-download if not mounted)release,nightly: Install wheels from PyPIskip: Skip Helion installationWhy this change?
Helion is an important framework supported by this repository. This dedicated setup script:
Testing:
Dependencies:
Related PRs:
🤖 Generated with Claude Code