Conversation
rrelledge
requested review from
a team,
AlonMagrafta,
LiorKogan,
gilcohen-pm,
maayanagranat,
pkm93,
shreyaverma-git and
yoavredis
Contributor
Contributor
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
dwdougherty
approved these changes
Apr 18, 2026
Collaborator
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
Just one comment about RQE. Otherwise, LGTM.
| | search-max-aggregate-results | integer (range: 0-9223372036854775807) (default: 2147483648) | The maximum number of results to be returned by the FT.AGGREGATE command if LIMIT is used | | ||
| | search-io-threads | integer (range: 1-256) (default: 1) | The number of threads the coordinator is using for IO threads to handle network to/from other shards | | ||
| | search-enable-unstable-features | boolean (default: false) | Enable unstable features. | | ||
| | search-index-cursor-limit | integer (range: 0-9223372036854775807) (default: 128) | The maximum number of cursors that can be opened, per shard, at any given time. Cursors can be opened by the user via FT.AGGREGATE WITHCURSOR. Cursors are also opened internally by the RQE for long-running queries. Once INDEX_CURSOR_LIMIT is reached, any further attempts to open a cursor will result in an error. | |
Collaborator
There was a problem hiding this comment.
Maybe change "the RQE" to "Redis Search"; RQE is obsolete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes staged preview: https://redis.io/docs/staging/DOC-6364/operate/rs/release-notes/rs-8-0-releases/rs-8-0-18-tba/
Still TODO:
Note
Low Risk
Documentation-only changes with no runtime code impact; main risk is inaccuracies in newly documented API fields/ports affecting operators if incorrect.
Overview
Documents Redis Software
8.0.18(Redis OSS8.6compatibility) by adding a newrs-8-0-18-tbarelease-notes page and updating the 8.0 release index to reflect the new feature set,crdb_controllerdefault enablement, and a newly reserved internal port (3357).Extends reference docs to match new capabilities: adds
allkeys-lrm/volatile-lrmeviction policies, updates the default bundled DB versions table to include8.6, documents the newPOST /v1/crdbs/{crdb_guid}/upgradeendpoint and correspondingupgrade_crdbpermission, and updates REST API objects (bdb,node, andbdb/search) with new fields/options (e.g.,replication_oom_threshold_percent,search_on_bigstore,oss_cluster_ip_mapping, and additional search config parameters).Reviewed by Cursor Bugbot for commit aaf0dea. Bugbot is set up for automated code reviews on this repo. Configure here.