Added custom Claude command + XNACK command support by vladvildanov · Pull Request #4030 · redis/redis-py

vladvildanov · 2026-04-09T12:06:09Z

Description of change

This PR contains:

New custom Claude command that enrich agent with necessary context and provides a clear guideline on how to add a support for given Redis command. Also it contains a command specification template to be used to provide custom command specification.
Support for XNACK command fully added using new Claude command.
Update to CONTRIBUTING.md about AI agent contributions.

Execute new command via CLI interface:

Augment CLI

auggie command add-new-command $path_to_specification

Claude CLI

claude /add-new-command $path_to_specification

Pull Request check-list

Please make sure to review and check all of these items:

Do tests and lints pass with this change?
Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
Is the new or changed code fully tested?
Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Note

Medium Risk
Adds a new core Redis Streams command (XNACK) with argument validation and new integration tests, which could affect client command coverage and behavior for stream consumers. Documentation-only additions for AI contribution workflows are low risk, but the command API change warrants a moderate review.

Overview
Adds support for the Redis Streams XNACK command to the core client API (sync + asyncio), including validation for required IDs, allowed mode values, and optional RETRYCOUNT/FORCE arguments.

Extends the integration test suite (sync and asyncio) to cover XNACK behavior and error cases, gated to Redis >= 8.8.0.

Introduces contributor-facing AI workflow docs: a .claude command-spec template and an add-new-command skill, plus a CONTRIBUTING.md section pointing contributors to available agent commands.

^{Reviewed by Cursor Bugbot for commit fee6e93. Bugbot is set up for automated code reviews on this repo. Configure here.}

jit-ci · 2026-04-09T12:09:47Z

🛡️ Jit Security Scan Results

✅ No security findings were detected in this PR

^{Security scan by Jit}

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit fee6e93. Configure here.}

cursor · 2026-04-09T12:10:35Z

+        if force:
+            pieces.append(b"FORCE")
+
+        return self.execute_command("XNACK", *pieces)


XNACK is a non-existent hallucinated Redis command

High Severity

XNACK is not an actual Redis command — it's an unimplemented feature request (redis/redis#5934, opened 2019, still labeled "needs-design"). The command's syntax, modes (SILENT, FAIL, FATAL), IDS count format, RETRYCOUNT, and FORCE options all appear to be AI-fabricated. Redis 8.8.0 (used in @skip_if_server_version_lt) doesn't exist either; the latest release is 8.6. This adds non-functional dead code that will always fail against any real Redis server.

Additional Locations (2)

tests/test_commands.py#L5988-L6101

tests/test_asyncio/test_commands.py#L4303-L4410

^{Reviewed by Cursor Bugbot for commit fee6e93. Configure here.}

Copilot

Pull request overview

Adds contributor tooling/docs for AI-assisted command additions and implements Redis Streams XNACK support in the core client API, along with new sync/async integration tests gated on Redis >= 8.8.0.

Changes:

Add xnack() to redis/commands/core.py (sync + asyncio typing overloads) with argument validation and command assembly.
Add integration tests for XNACK behavior and error handling (sync + asyncio).
Add contributor documentation and Claude skill/template files for adding new Redis command support.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`redis/commands/core.py`	Adds `xnack()` command implementation and typing overloads.
`tests/test_commands.py`	Adds sync integration tests for `XNACK` (Redis `>= 8.8.0`).
`tests/test_asyncio/test_commands.py`	Adds asyncio integration tests for `XNACK` (Redis `>= 8.8.0`).
`specs/redis_commands_guide.md`	New guide describing command API/spec workflow and repo structure.
`CONTRIBUTING.md`	Documents AI-driven contribution workflow and available CLI commands.
`.claude/commands/add-new-command.md`	New Claude “skill” instructions to add command support from a spec.
`.claude/command-specification-template.md`	New template for authoring command specifications.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

petyaslavova · 2026-04-09T15:26:38Z

+## Protocols compatibility
+
+SDK supports two types of Redis wire protocol: RESP2 and RESP3. And aims to provide a compatibility between them
+for seamless user experience. However, there are some differences in types that defined by these protocols.


types that defined --> types that are defined

petyaslavova · 2026-04-09T15:27:10Z

+SDK supports two types of Redis wire protocol: RESP2 and RESP3. And aims to provide a compatibility between them
+for seamless user experience. However, there are some differences in types that defined by these protocols.
+
+Because, RESP3 introduce new types that wasn't previously supported by RESP2, we're aiming for forward compatibility


types that wasn't --> types that weren't

petyaslavova · 2026-04-09T15:29:53Z

+see `redis/_parsers/resp2.py` and `redis/_parsers/resp3.py`.
+
+Parsers are responsible for RESP protocol parsing. However, protocols compatibility is achieved by 2nd layer
+parsing as `response_callbacks` defined in `redis/_parsers/helpers.py` and can be extended/updated on client level.


For modules the callbacks are defined usually in module's utils.py file

petyaslavova · 2026-04-09T15:32:03Z

        assert await r.xlen(stream) == 2

+    @skip_if_server_version_lt("8.8.0")
+    async def test_xnack_silent(self, r: redis.Redis):


The r type hint should also allow RedisCluster

The RC versions are usually coming with a little different version - for 8.8 we have 8.7.something. If we add these tests with this restriction, they won't actually get executed until we have a GA

vladvildanov added 2 commits April 9, 2026 13:05

Added custom Claude command + XNACK command support

a4c8ba7

Updated command description

fee6e93

vladvildanov requested a review from petyaslavova April 9, 2026 12:06

vladvildanov marked this pull request as draft April 9, 2026 12:06

vladvildanov requested a review from Copilot April 9, 2026 12:09

Copilot started reviewing on behalf of vladvildanov April 9, 2026 12:10 View session

cursor bot reviewed Apr 9, 2026

View reviewed changes

Copilot AI reviewed Apr 9, 2026

View reviewed changes

vladvildanov and others added 6 commits April 9, 2026 15:45

Update CONTRIBUTING.md

a8e4214

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update specs/redis_commands_guide.md

6cde5fe

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update specs/redis_commands_guide.md

f6f7483

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update specs/redis_commands_guide.md

71f04b1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update .claude/commands/add-new-command.md

87392ec

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update .claude/command-specification-template.md

91a0509

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

petyaslavova reviewed Apr 9, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added custom Claude command + XNACK command support#4030

Added custom Claude command + XNACK command support#4030
vladvildanov wants to merge 8 commits intomasterfrom
vv-xnack-support

vladvildanov commented Apr 9, 2026 •

edited

Loading

Uh oh!

jit-ci bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

cursor bot left a comment

Uh oh!

cursor bot Apr 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petyaslavova Apr 9, 2026

Uh oh!

petyaslavova Apr 9, 2026

Uh oh!

petyaslavova Apr 9, 2026

Uh oh!

petyaslavova Apr 9, 2026

Uh oh!

petyaslavova Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

vladvildanov commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of change

Pull Request check-list

Uh oh!

jit-ci bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛡️ Jit Security Scan Results

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Apr 9, 2026

Choose a reason for hiding this comment

XNACK is a non-existent hallucinated Redis command

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petyaslavova Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

petyaslavova Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

petyaslavova Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

petyaslavova Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

petyaslavova Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vladvildanov commented Apr 9, 2026 •

edited

Loading

jit-ci bot commented Apr 9, 2026 •

edited

Loading