Skip to content

Update GCRA argument names#4033

Open
petyaslavova wants to merge 2 commits intomasterfrom
ps_update_gcra_syntax
Open

Update GCRA argument names#4033
petyaslavova wants to merge 2 commits intomasterfrom
ps_update_gcra_syntax

Conversation

@petyaslavova
Copy link
Copy Markdown
Collaborator

@petyaslavova petyaslavova commented Apr 16, 2026

Renames the GCRA command interface to use token terminology:

  • requests-per-period becomes tokens-per-period
  • NUM_REQUESTS argument becomes TOKENS

The change is not breaking - it completes the changes to the new command that will be added as part of Redis's 8.8 release.

With this PR the latest build we use for 8.8 related changes is also updated.


Note

Medium Risk
This is an API-breaking rename for callers of gcra and changes the emitted Redis command option name, so downstream integrations may fail until updated.

Overview
Updates the gcra client API to use token-based naming: requests_per_period is renamed to tokens_per_period, and the optional NUM_REQUESTS argument is replaced with TOKENS (including validation error messages and command argument construction).

Updates both sync and asyncio test suites to use the new parameter/option names, and refreshes CI’s Redis 8.8 custom image tag in .github/workflows/integration.yaml.

Reviewed by Cursor Bugbot for commit 2a07ae1. Bugbot is set up for automated code reviews on this repo. Configure here.

@petyaslavova petyaslavova added the feature New feature label Apr 16, 2026
@jit-ci
Copy link
Copy Markdown

jit-ci bot commented Apr 16, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant