Open
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the GCRA command interface to use token terminology:
The change is not breaking - it completes the changes to the new command that will be added as part of Redis's 8.8 release.
With this PR the latest build we use for 8.8 related changes is also updated.
Note
Medium Risk
This is an API-breaking rename for callers of
gcraand changes the emitted Redis command option name, so downstream integrations may fail until updated.Overview
Updates the
gcraclient API to use token-based naming:requests_per_periodis renamed totokens_per_period, and the optionalNUM_REQUESTSargument is replaced withTOKENS(including validation error messages and command argument construction).Updates both sync and asyncio test suites to use the new parameter/option names, and refreshes CI’s Redis 8.8 custom image tag in
.github/workflows/integration.yaml.Reviewed by Cursor Bugbot for commit 2a07ae1. Bugbot is set up for automated code reviews on this repo. Configure here.