Fix Sync ClusterPubSub.disconnect() — Potential AttributeError#4036
Open
petyaslavova wants to merge 2 commits intomasterfrom
Open
Fix Sync ClusterPubSub.disconnect() — Potential AttributeError#4036petyaslavova wants to merge 2 commits intomasterfrom
petyaslavova wants to merge 2 commits intomasterfrom
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Sync ClusterPubSub.disconnect() — Potential AttributeError
Fixes a potential
AttributeErrorinClusterPubSub.disconnect()when a node's pubsub instance innode_pubsub_mappinghas aNoneconnection.The fix adds a guard check (
if pubsub.connection) before callingdisconnect(), consistent with the existing check already present forself.connection.Unit tests are added to verify that
disconnect()handlesNoneconnections gracefully and still properly disconnects non-None connections.Note
Low Risk
Small defensive change in cleanup logic with narrow behavioral impact; tests cover both
Noneand non-Noneconnection cases.Overview
Prevents
ClusterPubSub.disconnect()from raising anAttributeErrorby guardingpubsub.connection.disconnect()calls for entries innode_pubsub_mappingwhen theirconnectionisNone.Adds unit coverage to ensure
disconnect()is a no-op forNoneconnections and still callsdisconnect()on existing connections for both the main pubsub and per-node pubsubs.Reviewed by Cursor Bugbot for commit 2647923. Bugbot is set up for automated code reviews on this repo. Configure here.