Allow viewing basic properties of unknown files

Of course, we can only show you the raw hex and other basic
information but exploring this can now be done in a useful fashion.

Author: redstrate

apps/sagasu/include/filetreemodel.h

@@ -4,6 +4,8 @@
 #pragma once
 
 #include "hashdatabase.h"
+#include "physis.hpp"
+
 #include <QAbstractItemModel>
 #include <QFutureWatcher>
 
@@ -17,6 +19,8 @@ struct TreeInformation {
     QString name;
     int row = 0;
     uint32_t hash = 0;
+    Hash originalHash;
+    QString indexPath;
 
     std::vector<TreeInformation *> children;
 };
@@ -30,8 +34,10 @@ class FileTreeModel : public QAbstractItemModel
 
     enum CustomRoles {
         PathRole = Qt::UserRole,
-        IsUnknown,
-        IsFolder,
+        IsUnknownRole,
+        IsFolderRole,
+        HashRole,
+        IndexPathRole,
     };
 
     int rowCount(const QModelIndex &parent = QModelIndex()) const override;
@@ -48,7 +54,7 @@ class FileTreeModel : public QAbstractItemModel
     TreeInformation *rootItem = nullptr;
 
     void addKnownFolder(const QString &string);
-    void addFile(TreeInformation *parentItem, uint32_t filenameHash, const QString &name);
+    void addFile(TreeInformation *parentItem, uint32_t filenameHash, const QString &name, Hash originalHash, const QString &indexPath);
     void addFolder(TreeInformation *parentItem, uint32_t filenameHash);
 
     QHash<uint32_t, TreeInformation *> knownDirHashes;

apps/sagasu/include/filetreewindow.h

@@ -21,7 +21,7 @@ class FileTreeWindow : public QWidget
 
 Q_SIGNALS:
     void extractFile(const QString &path);
-    void pathSelected(const QString &path);
+    void pathSelected(const QString &indexPath, Hash hash, const QString &path);
 
 private:
     SqPackResource *data = nullptr;

apps/sagasu/include/mainwindow.h

@@ -35,5 +35,5 @@ class MainWindow : public KXmlGuiWindow
     QLabel *m_hashLabel = nullptr;
     QLabel *m_fileTypeLabel = nullptr;
 
-    void refreshParts(const QString &path);
+    void refreshParts(const QString &indexPath, Hash hash, const QString &path);
 };

apps/sagasu/src/filepropertieswindow.cpp

@@ -18,18 +18,20 @@ FilePropertiesWindow::FilePropertiesWindow(const QString &path, physis_Buffer bu
     auto layout = new QFormLayout();
     setLayout(layout);
 
-    auto pathLabel = new QLabel(path);
-    layout->addRow(i18nc("@label", "Path:"), pathLabel);
+    if (!path.isEmpty()) {
+        auto pathLabel = new QLabel(path);
+        layout->addRow(i18nc("@label", "Path:"), pathLabel);
 
-    QFileInfo info(path);
+        QFileInfo info(path);
 
-    const FileType type = FileTypes::getFileType(info.completeSuffix());
+        const FileType type = FileTypes::getFileType(info.completeSuffix());
 
-    auto typeLabel = new QLabel(FileTypes::getFiletypeName(type));
-    layout->addRow(i18nc("@label", "Type:"), typeLabel);
+        auto typeLabel = new QLabel(FileTypes::getFiletypeName(type));
+        layout->addRow(i18nc("@label", "Type:"), typeLabel);
+    }
 
     auto sizeLabel = new QLabel(QString::number(buffer.size));
     layout->addRow(i18nc("@label", "Size (in bytes):"), sizeLabel);
 }
 
-#include "moc_filepropertieswindow.cpp"
+#include "moc_filepropertieswindow.cpp"

apps/sagasu/src/filetreemodel.cpp

@@ -9,6 +9,8 @@
 #include <QIcon>
 #include <QtConcurrent>
 
+Q_DECLARE_METATYPE(Hash)
+
 FileTreeModel::FileTreeModel(HashDatabase &database, bool showUnknown, const QString &gamePath, SqPackResource *data, QObject *parent)
     : QAbstractItemModel(parent)
     , gameData(data)
@@ -28,16 +30,26 @@ FileTreeModel::FileTreeModel(HashDatabase &database, bool showUnknown, const QSt
         QFileInfo info = it.fileInfo();
         if (info.exists() && (info.completeSuffix() == QStringLiteral("win32.index"))) {
             std::string pathStd = info.filePath().toStdString();
-            auto indexEntries = physis_index_parse(pathStd.c_str());
-            for (uint32_t i = 0; i < indexEntries.num_entries; i++) {
-                if (knownDirHashes.contains(indexEntries.dir_entries[i])) {
-                    QString name;
-                    if (m_database.knowsFile(indexEntries.filename_entries[i])) {
-                        name = m_database.getFilename(indexEntries.filename_entries[i]);
+            const auto indexEntries = physis_index_parse(pathStd.c_str());
+            for (uint32_t i = 0; i < indexEntries.num_hashes; i++) {
+                const auto hash = indexEntries.hashes[i];
+                switch (hash.tag) {
+                case Hash::Tag::SplitPath: {
+                    const auto completeHash =
+                        static_cast<uint32_t>(static_cast<uint64_t>(hash.split_path.path) << 32 | static_cast<uint64_t>(hash.split_path.name));
+                    if (knownDirHashes.contains(hash.split_path.path)) {
+                        QString name;
+                        if (m_database.knowsFile(completeHash)) {
+                            name = m_database.getFilename(completeHash);
+                        }
+                        addFile(knownDirHashes[hash.split_path.path], completeHash, name, hash, info.filePath());
+                    } else {
+                        addFolder(rootItem, hash.split_path.path);
                     }
-                    addFile(knownDirHashes[indexEntries.dir_entries[i]], indexEntries.filename_entries[i], name);
-                } else {
-                    addFolder(rootItem, indexEntries.dir_entries[i]);
+                } break;
+                case Hash::Tag::FullPath:
+                    Q_UNREACHABLE(); // shouldn't be in basic index files
+                    break;
                 }
             }
         }
@@ -122,10 +134,14 @@ QVariant FileTreeModel::data(const QModelIndex &index, int role) const
         }
 
         return path;
-    } else if (role == IsUnknown) {
+    } else if (role == IsUnknownRole) {
         return item->name.isEmpty(); // unknown files/folders have no name (obviously, we don't know what its named!)
-    } else if (role == IsFolder) {
+    } else if (role == IsFolderRole) {
         return item->type == TreeType::Folder;
+    } else if (role == HashRole) {
+        return QVariant::fromValue(item->originalHash);
+    } else if (role == IndexPathRole) {
+        return item->indexPath;
     } else if (role == Qt::DisplayRole) {
         if (item->type == TreeType::Folder) {
             if (item->name.isEmpty()) {
@@ -194,7 +210,7 @@ void FileTreeModel::addKnownFolder(const QString &string)
     }
 }
 
-void FileTreeModel::addFile(TreeInformation *parentItem, uint32_t name, const QString &realName)
+void FileTreeModel::addFile(TreeInformation *parentItem, uint32_t name, const QString &realName, Hash originalHash, const QString &indexPath)
 {
     if (realName.isEmpty() && !m_showUnknown) {
         return;
@@ -206,6 +222,8 @@ void FileTreeModel::addFile(TreeInformation *parentItem, uint32_t name, const QS
     fileItem->type = TreeType::File;
     fileItem->parent = parentItem;
     fileItem->row = parentItem->children.size();
+    fileItem->originalHash = originalHash;
+    fileItem->indexPath = indexPath;
 
     parentItem->children.push_back(fileItem);
 }

apps/sagasu/src/filetreewindow.cpp

@@ -46,14 +46,6 @@ FileTreeWindow::FileTreeWindow(HashDatabase &database, const QString &gamePath,
     });
     layout->addWidget(searchEdit);
 
-    // TODO Restore as an action, later. it's currently pretty useless as-is as it's a "please slow down and crash" checkbox
-    /*m_unknownCheckbox = new QCheckBox();
-    m_unknownCheckbox->setToolTip(QStringLiteral("Show unknown files and folders."));
-    connect(m_unknownCheckbox, &QCheckBox::clicked, this, [this] {
-        refreshModel();
-    });
-    searchLayout->addWidget(m_unknownCheckbox);*/
-
     auto treeWidget = new QTreeView();
     treeWidget->setModel(m_searchModel);
     layout->addWidget(treeWidget);
@@ -64,8 +56,8 @@ FileTreeWindow::FileTreeWindow(HashDatabase &database, const QString &gamePath,
 
         if (index.isValid()) {
             const auto path = m_searchModel->data(index, FileTreeModel::CustomRoles::PathRole).toString();
-            const auto isUnknown = m_searchModel->data(index, FileTreeModel::CustomRoles::IsUnknown).toBool();
-            const auto isFolder = m_searchModel->data(index, FileTreeModel::CustomRoles::IsFolder).toBool();
+            const auto isUnknown = m_searchModel->data(index, FileTreeModel::CustomRoles::IsUnknownRole).toBool();
+            const auto isFolder = m_searchModel->data(index, FileTreeModel::CustomRoles::IsFolderRole).toBool();
 
             auto menu = new QMenu();
 
@@ -94,8 +86,16 @@ FileTreeWindow::FileTreeWindow(HashDatabase &database, const QString &gamePath,
 
     connect(treeWidget, &QTreeView::clicked, [this, treeWidget](const QModelIndex &item) {
         if (item.isValid()) {
-            auto path = m_searchModel->data(item, FileTreeModel::CustomRoles::PathRole).toString();
-            Q_EMIT pathSelected(path);
+            const auto isFolder = m_searchModel->data(item, FileTreeModel::CustomRoles::IsFolderRole).toBool();
+            if (isFolder) {
+                return;
+            }
+
+            const auto path = m_searchModel->data(item, FileTreeModel::CustomRoles::PathRole).toString();
+            const auto indexPath = m_searchModel->data(item, FileTreeModel::CustomRoles::IndexPathRole).toString();
+            const auto hash = m_searchModel->data(item, FileTreeModel::CustomRoles::HashRole).value<Hash>();
+
+            Q_EMIT pathSelected(indexPath, hash, path);
         }
     });
 

apps/sagasu/src/mainwindow.cpp

@@ -78,8 +78,8 @@ MainWindow::MainWindow(const QString &gamePath, SqPackResource *data)
             file.write(reinterpret_cast<const char *>(fileData.data), fileData.size);
         }
     });
-    connect(m_tree, &FileTreeWindow::pathSelected, this, [this](const QString &path) {
-        refreshParts(path);
+    connect(m_tree, &FileTreeWindow::pathSelected, this, [this](const QString &indexPath, Hash hash, const QString &path) {
+        refreshParts(indexPath, hash, path);
     });
     m_tree->setMaximumWidth(300);
     dummyWidget->addWidget(m_tree);
@@ -89,7 +89,7 @@ MainWindow::MainWindow(const QString &gamePath, SqPackResource *data)
     partHolder->setMinimumHeight(720);
     dummyWidget->addWidget(partHolder);
 
-    refreshParts({});
+    refreshParts({}, {}, {});
 
     setupActions();
     setupGUI(Keys | Save | Create, QStringLiteral("dataexplorer.rc"));
@@ -100,27 +100,35 @@ MainWindow::MainWindow(const QString &gamePath, SqPackResource *data)
     actionCollection()->removeAction(actionCollection()->action(KStandardAction::name(KStandardAction::AboutKDE)));
 }
 
-void MainWindow::refreshParts(const QString &path)
+void MainWindow::refreshParts(const QString &indexPath, Hash hash, const QString &path)
 {
     partHolder->clear();
 
     std::string pathStd = path.toStdString();
-    if (path.isEmpty() || !physis_gamedata_exists(data, pathStd.c_str())) {
+    if (indexPath.isEmpty()) {
         return;
     }
 
     QFileInfo info(path);
     std::string filenameStd = info.fileName().toStdString();
 
-    // FIXME: add back once hashes are f igured out
+    // FIXME: add back once hashes are figured out
     // auto crcHash = physis_calculate_hash(filenameStd.c_str());
     // m_hashLabel->setText(i18n("Hash: 0x%1", QString::number(crcHash, 16).toUpper().rightJustified(8, QLatin1Char('0'))));
 
     // FIXME: this is terrible, we should not be recalculating this. it isn't a huge deal with the file + index caching, but still
-    auto datOffset = physis_gamedata_find_offset(data, pathStd.c_str());
-    m_offsetLabel->setText(i18n("Offset: 0x%1", QString::number(datOffset, 16).toUpper().rightJustified(8, QLatin1Char('0'))));
+    // TODO: support for unknown files
+    if (!path.isEmpty()) {
+        auto datOffset = physis_gamedata_find_offset(data, pathStd.c_str());
+        m_offsetLabel->setText(i18n("Offset: 0x%1", QString::number(datOffset, 16).toUpper().rightJustified(8, QLatin1Char('0'))));
+    } else {
+        m_offsetLabel->setText(i18n("Offset: Unknown"));
+    }
 
-    auto file = physis_gamedata_extract_file(data, path.toStdString().c_str());
+    auto file = physis_gamedata_extract_file_from_hash(data, indexPath.toStdString().c_str(), hash);
+    if (file.size == 0) {
+        return;
+    }
 
     const FileType type = FileTypes::getFileType(info.completeSuffix());