chore(toolkit): remove unnecessary areErrorsEqual function#5216
Merged
EskiMojo14 merged 1 commit intoreduxjs:masterfrom Feb 6, 2026
Merged
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
2 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d4604cc:
|
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
EskiMojo14
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
vitestalready internally uses an error-comparison helper,isErrorEqual, so our localareErrorsEqualequality-tester is redundant.isErrorEqualwas introduced upstream in vitest-dev/vitest#5876 and covers our use case (including correctly differentiating error types). With the current version ofvitest, the tests fail if we swap (for example) aTypeErrorfor anError, which matches the behavior we want and confirms we can safely removeareErrorsEqualwithout changing test intent.This PR:
areErrorsEqualequality-tester.Additional Notes
"moduleResolution": "bundler"#5206.