fix(mui): remove nested interactive elements from button components #7094
+278
−332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed accessibility issue where button components rendered a button inside an anchor. This caused keyboard navigation issues and violated accessibility guidelines. Updated CreateButton, EditButton, CloneButton, ListButton, and ShowButton to use MUI Button component prop instead of nesting elements. Resolves refinedev#7085
🦋 Changeset detectedLatest commit: a011a43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for refine-doc-live-previews ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
alicanerdurmaz
requested changes
Nov 12, 2025
Member
alicanerdurmaz
left a comment
alicanerdurmaz
left a comment
There was a problem hiding this comment.
Hello @ctonneslan, your PR is great, thank you. I also made a couple of changes:
- Refactored the link in the
<ThemedTitle />component using your method. - Updated the
@refinedev/inferencertests.
However, the button tests are still failing. Could you take a look at them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
componentproptextDecoration: "none"style to the Button's sx proponClickhandler to the Button componentContext
The previous implementation wrapped a
<Button>element inside a<LinkComponent>(anchor tag), creating nested interactive elements. This violates accessibility guidelines and causes issues:Solution
Material UI's Button component supports rendering as different components via the
componentprop. By passingcomponent={LinkComponent}, the Button renders directly as a link, maintaining all navigation functionality without the nested structure.Test Plan
Affected Components
Resolves #7085