REDCap UI bug fixes from testing#1
Merged
regisoc merged 1 commit intoApr 3, 2026
Merged
Conversation
MaximeBICMTL
force-pushed
the
regis_redcap_ui_pr_fix
branch
from
68d6d9c to
fce2cc3
Compare
regisoc
pushed a commit
that referenced
this pull request
Mar 16, 2026
PHP Fatal error: Uncaught TypeError: Project::getProjectFromID(): Argument #1 ($projectID) must be of type ProjectID, int given, called
regisoc
pushed a commit
that referenced
this pull request
Mar 16, 2026
This fixes the following errors when running the tool `fix_timepoint_date_problems.php` ``` PHP Fatal error: Uncaught TypeError: preg_match(): Argument aces#2 ($subject) must be of type string, LORIS\StudyEntities\Candidate\CandID given in /var/www/Loris/tools/fix_timepoint_date_problems.php:157 Stack trace: #0 /var/www/Loris/tools/fix_timepoint_date_problems.php(157): preg_match() #1 {main} thrown in /var/www/Loris/tools/fix_timepoint_date_problems.php on line 157 ``` ``` PHP Fatal error: Uncaught TypeError: checkdate(): Argument #1 ($month) must be of type int, string given in /var/www/Loris/tools/fix_timepoint_date_problems.php:519 Stack trace: #0 /var/www/Loris/tools/fix_timepoint_date_problems.php(519): checkdate() #1 /var/www/Loris/tools/fix_timepoint_date_problems.php(244): fixDate() aces#2 {main} thrown in /var/www/Loris/tools/fix_timepoint_date_problems.php on line 519 ``` ``` PHP Warning: Undefined variable $db in /var/www/Loris/php/libraries/NDB_BVL_Feedback.class.inc on line 717 PHP Fatal error: Uncaught Error: Call to a member function pselectOne() on null in /var/www/Loris/php/libraries/NDB_BVL_Feedback.class.inc:717 Stack trace: #0 /var/www/Loris/tools/fix_timepoint_date_problems.php(553): NDB_BVL_Feedback->createThread() #1 /var/www/Loris/tools/fix_timepoint_date_problems.php(244): fixDate() aces#2 {main} thrown in /var/www/Loris/php/libraries/NDB_BVL_Feedback.class.inc on line 717 ```
regisoc
pushed a commit
that referenced
this pull request
Mar 16, 2026
The REDcap "radio option" sometimes includes no index and, in this case, a decimal (float) causing redcap2linst show the following error: PHP Fatal error: Uncaught DomainException: Could not parse radio option: '0.01 ' in /var/www/loris/project/modules/redcap/php/client/models/redcapdictionaryrecord.class.inc:316 Stack trace: #0 /var/www/loris/project/modules/redcap/php/client/models/redcapdictionaryrecord.class.inc(268): LORIS\redcap\client\models\RedcapDictionaryRecord->_optionsToLINST() #1 /var/www/loris/project/tools/redcap2linst.php(74): LORIS\redcap\client\models\RedcapDictionaryRecord->toLINST() aces#2 {main} thrown in /var/www/loris/project/modules/redcap/php/client/models/redcapdictionaryrecord.class.inc on line 316 the fetch was 0.01 | 0.05 | 0.10 | 0.15 without indices, But this code fixes it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of fixes:
QueriestoRedcapQueries.FormNametoInstrumentNameto match the SQL schema..gitignorefile so that the compiled Javascript files do not pollute the git tree.