Skip to content

Conversation

@frnandu
Copy link
Collaborator

@frnandu frnandu commented Nov 12, 2024

since the signer is injected into many usecases, we cannot later replace it without causing problems. So if client needs to change the signer, it should create a new instance of ndk

@frnandu frnandu requested a review from 1-leo November 12, 2024 16:06
@codecov
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.71%. Comparing base (b33b78e) to head (2d64600).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   63.72%   63.71%   -0.01%     
==========================================
  Files          59       59              
  Lines        2172     2169       -3     
==========================================
- Hits         1384     1382       -2     
+ Misses        788      787       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frnandu frnandu closed this Nov 12, 2024
@frnandu frnandu deleted the remove-change-event-signer branch November 12, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants