Skip to content

Conversation

@frnandu
Copy link
Collaborator

@frnandu frnandu commented Nov 25, 2024

Split into monorepos, so that ndk can dependency free from flutter

  • ndk
  • amber
  • rust_verifier
  • objectbox
  • sample-app

fixes #24

@codecov
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.87%. Comparing base (8921036) to head (d94a8a3).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
...s/ndk/lib/domain_layer/usecases/relay_manager.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   65.29%   61.87%   -3.42%     
==========================================
  Files          71       72       +1     
  Lines        2573     2741     +168     
==========================================
+ Hits         1680     1696      +16     
- Misses        893     1045     +152     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frnandu frnandu requested a review from 1-leo November 25, 2024 16:00
Copy link
Contributor

@1-leo 1-leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

rxdart: ^0.28.0
flutter_rust_bridge: 2.6.0
rust_lib_ndk: ^0.1.3
ndk:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work when publishing a package? Is melos smart enouth to replace with the new deployed version when pushing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, to be tested/researched

@frnandu frnandu merged commit 0905731 into master Nov 26, 2024
@frnandu frnandu deleted the melos-monorepo branch December 4, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

melos

3 participants