Skip to content
This repository was archived by the owner on Mar 7, 2026. It is now read-only.

Fixed build issues with small zIndex change.#513

Merged
milaiwi merged 2 commits intoreorproject:mainfrom
milaiwi:main
Apr 5, 2025
Merged

Fixed build issues with small zIndex change.#513
milaiwi merged 2 commits intoreorproject:mainfrom
milaiwi:main

Conversation

@milaiwi
Copy link
Copy Markdown
Collaborator

@milaiwi milaiwi commented Apr 1, 2025

  • Fixed small zIndex error on SideMenuPositioner that allowed it to display above a Dialog.
  • Fixed build issue that was causing errors on macOS.

Copy link
Copy Markdown

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes a zIndex stacking issue in the SideMenuPositioner and resolves macOS build errors by adjusting build configurations.

• Updated src/lib/blocknote/react/SideMenu/components/SideMenuPositioner.tsx to set Tippy's zIndex to 40, preventing Dialog overlap.
• Modified electron-builder.json5 to explicitly set the main entry to dist-electron/main/index.js.
• package.json now includes "dist_electron/**/*", which may require alignment with the "dist-electron" naming convention.
• Revised .tamagui/tamagui-components.config.cjs imports and zIndex globals for dependency updates.
• Adjusted vite.config.mts for enhanced module resolution and tamaguiPlugin compatibility.

💡 (5/5) You can turn off certain types of comments like style here!

5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Comment thread package.json Outdated
Comment on lines +5 to +6
"main": "dist-electron/main/index.js",
"files": ["dist_electron/**/*", "dist/**/*"],
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Folder name mismatch: 'main' uses 'dist-electron' (dash) but 'files' uses 'dist_electron' (underscore). Fix to ensure consistent folder names.

Suggested change
"main": "dist-electron/main/index.js",
"files": ["dist_electron/**/*", "dist/**/*"],
"main": "dist-electron/main/index.js",
"files": ["dist-electron/**/*", "dist/**/*"],

@milaiwi
Copy link
Copy Markdown
Collaborator Author

milaiwi commented Apr 1, 2025

@weilirs Can you approve this so I can merge?

@weilirs
Copy link
Copy Markdown
Collaborator

weilirs commented Apr 1, 2025

@weilirs Can you approve this so I can merge?

I checked out this PR and ran npm run build I got this error

error during build:
TypeError: (intermediate value).resolve is not a function
    at resolve (file:///Users/macbookpro/Documents/Reor2/node_modules/@tamagui/vite-plugin/dist/esm/plugin.mjs:5:51)
    at config (file:///Users/macbookpro/Documents/Reor2/node_modules/@tamagui/vite-plugin/dist/esm/plugin.mjs:71:68)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async runConfigHook (file:///Users/macbookpro/Documents/Reor2/node_modules/vite/dist/node/chunks/dep-4f6e688c.js:66592:25)
    at async resolveConfig (file:///Users/macbookpro/Documents/Reor2/node_modules/vite/dist/node/chunks/dep-4f6e688c.js:66027:14)
    at async build (file:///Users/macbookpro/Documents/Reor2/node_modules/vite/dist/node/chunks/dep-4f6e688c.js:47929:20)
    at async CAC.<anonymous> (file:///Users/macbookpro/Documents/Reor2/node_modules/vite/dist/node/cli.js:843:9)

@milaiwi
Copy link
Copy Markdown
Collaborator Author

milaiwi commented Apr 1, 2025

Did you run clear node_modules, re-installed them, then run npm run build?

@weilirs
Copy link
Copy Markdown
Collaborator

weilirs commented Apr 1, 2025

Did you run clear node_modules, re-installed them, then run npm run build?

this is what I ran before build

rm -rf node_modules
rm -f package-lock.json
npm cache clean --force
npm install

@milaiwi milaiwi merged commit 80f6ab6 into reorproject:main Apr 5, 2025
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants