Fixed build issues with small zIndex change.#513
Conversation
There was a problem hiding this comment.
PR Summary
This PR fixes a zIndex stacking issue in the SideMenuPositioner and resolves macOS build errors by adjusting build configurations.
• Updated src/lib/blocknote/react/SideMenu/components/SideMenuPositioner.tsx to set Tippy's zIndex to 40, preventing Dialog overlap.
• Modified electron-builder.json5 to explicitly set the main entry to dist-electron/main/index.js.
• package.json now includes "dist_electron/**/*", which may require alignment with the "dist-electron" naming convention.
• Revised .tamagui/tamagui-components.config.cjs imports and zIndex globals for dependency updates.
• Adjusted vite.config.mts for enhanced module resolution and tamaguiPlugin compatibility.
💡 (5/5) You can turn off certain types of comments like style here!
5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| "main": "dist-electron/main/index.js", | ||
| "files": ["dist_electron/**/*", "dist/**/*"], |
There was a problem hiding this comment.
logic: Folder name mismatch: 'main' uses 'dist-electron' (dash) but 'files' uses 'dist_electron' (underscore). Fix to ensure consistent folder names.
| "main": "dist-electron/main/index.js", | |
| "files": ["dist_electron/**/*", "dist/**/*"], | |
| "main": "dist-electron/main/index.js", | |
| "files": ["dist-electron/**/*", "dist/**/*"], |
|
@weilirs Can you approve this so I can merge? |
I checked out this PR and ran |
|
Did you run clear node_modules, re-installed them, then run |
this is what I ran before build |
zIndexerror onSideMenuPositionerthat allowed it to display above aDialog.