This repository was archived by the owner on Mar 7, 2026. It is now read-only.
chore(nav): remove New Note and New Directory buttons from nav (moved to Files sidebar header)#527
Open
danhilse wants to merge 2 commits intoreorproject:mainfrom
Open
chore(nav): remove New Note and New Directory buttons from nav (moved to Files sidebar header)#527danhilse wants to merge 2 commits intoreorproject:mainfrom
danhilse wants to merge 2 commits intoreorproject:mainfrom
Conversation
…es sidebar for quicker access
… to Files sidebar header)
There was a problem hiding this comment.
Greptile Summary
This PR relocates the "New Note" and "New Directory" buttons from the main navigation (IconsSidebar) to the Files sidebar header (FileSidebar). This is a UI/UX improvement that groups file creation actions with the file management interface rather than having them scattered in the main navigation.
The changes involve:
In IconsSidebar.tsx:
- Removes unused imports (
VscNewFolder,HiOutlinePencilAlt) - Removes the
useContentContexthook that's no longer needed - Removes
setIsNewDirectoryModalOpenfrom the modal context destructuring - Eliminates the button rendering logic for these two actions
In FileSidebar.tsx:
- Adds necessary imports for
useModalOpenersanduseContentContext - Imports the required icons (
VscNewFolder,HiOutlinePencilAlt) - Creates a new header section with both buttons in a horizontal layout
- Uses consistent styling patterns with other interactive elements (YStack containers, hover effects, opacity transitions)
- Integrates with existing functionality:
createUntitledNote()for new notes and the modal system for new directories
This refactoring follows the application's existing design patterns and maintains all original functionality while improving the logical organization of the interface. The buttons retain their original behavior but are now contextually placed where users would expect file creation actions to be.
Confidence score: 4/5
- This PR is safe to merge with minimal risk as it's a straightforward UI reorganization
- Score reflects clean refactoring with proper cleanup and consistent styling, but lacks explicit testing
- Pay attention to FileSidebar.tsx to ensure the new header doesn't affect existing layout calculations
2 files reviewed, no comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR from fork branch 'feature/qol-sidebar-actions'.