update Rerun API V0.18.2 #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfoldi
commented
Oct 2, 2024
| rec.log(entity_path, rerun::Image(tensor_shape(img), rerun::TensorBuffer::u8(img))); | ||
| rec.log( | ||
| entity_path, | ||
| rerun::Image::from_rgb24(rerun::Collection<uint8_t>(img), width_height(img)) |
There was a problem hiding this comment.
I honestly don't know what is the proper way to use CollectionAdapters here. Without contstructor/casting it does not compile and I yet to find a recent example that works
|
since I was here I fixed #17 and added |
emilk
reviewed
Oct 3, 2024
emilk
approved these changes
Oct 3, 2024
| rec.log(entity_path, rerun::Image(tensor_shape(img), rerun::TensorBuffer::u8(img))); | ||
| rec.log( | ||
| entity_path, | ||
| rerun::Image::from_rgb24(rerun::Collection<uint8_t>(img), width_height(img)) |
There was a problem hiding this comment.
Seems related to this issue:
But I think this code this is fine, since it borrows data that lives longer than rerun::Image
Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump API version, update log calls, fix #17