feat: generic annotations labels#119
Merged
Merged
Conversation
closes #45 users can now specify custom labels and annotations in the spec that will be passed down to the created workloads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #45
this PR allows users to specify custom labels and annotations that they want the controller to put on the created workload (sts->pods). it's option, so no impact on existing users. non-breaking expansion of CRD.
there were no tests covering this part of the code before, so i've added some that cover the existing and new behaviour.
and added a note in the readme about what happens if you have internal and user intents setting the same key.