fix: route Knative service URLs through cloud tunnel when using Restate Cloud#122
Merged
Merged
Conversation
…te Cloud The Knative reconciler was passing the raw in-cluster Route URL directly to register_service_with_restate, which Restate Cloud cannot reach. This adds maybe_tunnel_url() to RestateAdminEndpoint and uses it in the Knative path, matching the existing ReplicaSet behavior. Also simplifies service_url() to use the same method internally. Closes restatedev#120 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lukebond
approved these changes
Apr 16, 2026
Contributor
lukebond
left a comment
lukebond
left a comment
There was a problem hiding this comment.
thank you!
i just did a release but haven't announced it anywhere. i'll do a follow-up patch release for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Knative reconciler was passing the raw in-cluster Route URL directly
to register_service_with_restate, which Restate Cloud cannot reach. This
adds maybe_tunnel_url() to RestateAdminEndpoint and uses it in the
Knative path, matching the existing ReplicaSet behavior. Also simplifies
service_url() to use the same method internally.
Closes #120