Use journal table v2 as default #3921
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ice invocation ingestion logic to write the journal v2
… and then tries to read from journal table v1
slinkydeveloper
force-pushed
the
issues/3184-add-feature-flag
branch
7 times, most recently
from
443e68d to
257c1d9
Compare
slinkydeveloper
changed the title
|
This is ready for an initial pass. The test is failing because i still didn't figure out how to do the exclusion properly 🫨 but the exclusion is legit |
…tever reason the negotiated protocol when invoking will be less than 4.
…he problematic situations. Fix some incorrectly handled corner cases, such as deletion of journal when the pinned deployment is not set yet.
…tion. See the changes for more details.
slinkydeveloper
force-pushed
the
issues/3184-add-feature-flag
branch
from
257c1d9 to
60b2632
Compare
|
|
This case can happen if we got an invocation scheduled (or inboxed) before the journal v2 default feature was enabled.
|
Fixed the problem with exclusions! |
|
did some manual testing locally, primarily around scheduled invocations, first disabling then enabling, and viceversa. So far everything seems to work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3184