Fix Ambitus color and visibility propagation #4
Conversation
This commit fixes a bug where child elements of an Ambitus were not updated when the Ambitus was colored or hidden. The `Ambitus::setProperty` method has been updated to intercept `setProperty` calls for `Pid::COLOR` and `Pid::VISIBLE`. For these properties, the call is first forwarded to the top and bottom accidental children. A fallthrough to the default case is then used to ensure the property is also set on the Ambitus itself.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This change fixes a bug where child elements of an Ambitus were not updated when the Ambitus was colored or hidden. The
setPropertymethod in theAmbitusclass is updated to propagate color and visibility changes to its child accidentals.PR created automatically by Jules for task 17503803355517971360 started by @rettinghaus