-
Notifications
You must be signed in to change notification settings - Fork 21
feat: StatelessValidatorMultiPlexer #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new StatelessValidatorMultiPlexer module that enables multiple stateless validators to be used together in a single validation operation. The implementation allows for composition of different validator types (e.g., ECDSA and WebAuthn) where all validators must pass for the overall validation to succeed.
- Implements a new multiplexer contract that validates signatures by calling multiple stateless validators
- Adds comprehensive test coverage for various validation scenarios including edge cases
- Updates Solidity version from 0.8.25 to 0.8.28 across the project
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/StatelessValidatorMultiPlexer/StatelessValidatorMultiPlexer.sol |
Core multiplexer implementation with signature validation logic |
test/StatelessValidatorMultiPlexer/StatelessValidatorMultiPlexer.sol |
Comprehensive test suite covering success/failure scenarios |
foundry.toml |
Updates Solidity compiler version to 0.8.28 |
.vscode/settings.json |
Configures VS Code to use Solidity 0.8.28 |
Comments suppressed due to low confidence (2)
test/StatelessValidatorMultiPlexer/StatelessValidatorMultiPlexer.sol:124
- The test
test_OnInstallonly assertsassertTrue(true)which provides no meaningful validation. Consider testing actual behavior or state changes.
assertTrue(true);
test/StatelessValidatorMultiPlexer/StatelessValidatorMultiPlexer.sol:129
- The test
test_OnUninstallonly assertsassertTrue(true)which provides no meaningful validation. Consider testing actual behavior or state changes.
assertTrue(true);
No description provided.