Skip to content

refactor: support c++20#1132

Open
fxliang wants to merge 4 commits intorime:masterfrom
fxliang:fixu8str
Open

refactor: support c++20#1132
fxliang wants to merge 4 commits intorime:masterfrom
fxliang:fixu8str

Conversation

@fxliang
Copy link
Copy Markdown
Contributor

@fxliang fxliang commented Jan 24, 2026 •
edited
Loading

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #
fix: #1131

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@fxliang fxliang requested review from a team and lotem January 24, 2026 07:48
@fxliang fxliang changed the title fix: rime::path to ostream fails with c++20 fix: rime::path to ostream fails with c++20[wip] Jan 24, 2026
@lotem
Copy link
Copy Markdown
Member

lotem commented Jan 24, 2026

It's the correct way to do type conversion.
But it is confusing to have a different member function with similar name.

lotem
lotem reviewed Jan 24, 2026
View reviewed changes
src/rime/dict/vocabulary.h
double weight = 0.0;

ShortDictEntry() = default;
ShortDictEntry(const string& t, const Code& c, double w)
Copy link
Copy Markdown
Member

@lotem lotem Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this change for?

Copy link
Copy Markdown
Contributor Author

@fxliang fxliang Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c++20

@fxliang fxliang changed the title fix: rime::path to ostream fails with c++20[wip] fix: rime::path to ostream fails with c++20 Jan 25, 2026
@fxliang
Copy link
Copy Markdown
Contributor Author

fxliang commented Jan 25, 2026

It's the correct way to do type conversion. But it is confusing to have a different member function with similar name.

maybe s solution is to rename utf8string to string_utf8

@lotem
Copy link
Copy Markdown
Member

lotem commented Jan 25, 2026

It's the correct way to do type conversion. But it is confusing to have a different member function with similar name.

maybe s solution is to rename utf8string to string_utf8

OK. I don't have any better ideas.

@fxliang fxliang changed the title fix: rime::path to ostream fails with c++20 refactor: support c++20 Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lotem lotem lotem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

C++20 编译失败

2 participants

@fxliang @lotem