Skip to content

Fix Japanese translations for clarity and accuracy #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rindrics merged 2 commits into from
Mar 8, 2026
Merged

Fix Japanese translations for clarity and accuracy #140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ae3c3d
Fix Japanese translations for clarity and accuracy
rindrics Mar 5, 2026
b9a4b18
Fix Japanese text formatting in 1.yaml
rindrics Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions contents/input/daxue/1/1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,31 +5,31 @@ segments:
speaker: null
- text:
original: 在明明德 在親民 在止於至善
japanese: 明徳を明らかにするに在り、民を親（した）しましむるに在り、至善に止まるに在り。
japanese: 明徳を明らかにするに在り、民を親（ちか）しましむるに在り、至善に止まるに在り。
speaker: null
- text:
original: 知止而后有定
japanese: 止まることを知りて后に定まること有り、
japanese: 止まることを知りて后 定まる有り、
speaker: null
- text:
original: 定而后能靜
japanese: 定まりて后に能く静かなり、
japanese: 定まりて后 能く静かに、
speaker: null
- text:
original: 靜而后能安
japanese: 静かにして后に能く安く、
japanese: 静かにして后 能く安く、
speaker: null
- text:
original: 安而后能慮
japanese: 安くして后に能く慮る、
japanese: 安くして后 能く慮り、
speaker: null
- text:
original: 慮而后能得
japanese: 慮りて后能く得（う）。
japanese: 慮りて后 能く得（う）。
Comment on lines +12 to +28

@coderabbitai coderabbitai Bot Mar 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove the visible spaces after 后.

The spaces on Line 12, Line 16, Line 20, Line 24, and Line 28 will render as literal gaps in the Japanese text. They read like accidental formatting and are inconsistent with the rest of this file.

Suggested edit 
-      japanese: 止まることを知りて后 定まる有り、
+      japanese: 止まることを知りて后定まる有り、
-      japanese: 定まりて后 能く静かに、
+      japanese: 定まりて后能く静かに、
-      japanese: 静かにして后 能く安く、
+      japanese: 静かにして后能く安く、
-      japanese: 安くして后 能く慮り、
+      japanese: 安くして后能く慮り、
-      japanese: 慮りて后 能く得（う）。
+      japanese: 慮りて后能く得（う）。
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
japanese: 止まることを知りて后 定まる有り、
speaker: null
- text:
original: 定而后能靜
japanese: 定まりて后に能く静かなり、
japanese: 定まりて后 能く静かに、
speaker: null
- text:
original: 靜而后能安
japanese: 静かにして后に能く安く、
japanese: 静かにして后 能く安く、
speaker: null
- text:
original: 安而后能慮
japanese: 安くして后に能く慮る、
japanese: 安くして后 能く慮り、
speaker: null
- text:
original: 慮而后能得
japanese: 慮りて后能く得（う）。
japanese: 慮りて后 能く得（う）。
japanese: 止まることを知りて后定まる有り、
speaker: null
- text:
original: 定而后能靜
japanese: 定まりて后能く静かに、
speaker: null
- text:
original: 靜而后能安
japanese: 静かにして后能く安く、
speaker: null
- text:
original: 安而后能慮
japanese: 安くして后能く慮り、
speaker: null
- text:
original: 慮而后能得
japanese: 慮りて后能く得（う）。
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@contents/input/daxue/1/1.yaml` around lines 12 - 28, In the YAML entries
where text.original values like "定而后能靜", "靜而后能安", "安而后能慮", and "慮而后能得" are
paired with japanese translations, remove the visible space immediately
following the character "后" in each corresponding text.japanese value (the
entries currently showing "后 定まる有り", "后 能く静かに、", "后 能く安く、", "后 能く慮り、", "后
能く得（う）。") so the Japanese strings read without the accidental gap (e.g.,
"后定まる有り", "后能く静かに、", etc.); update the text.japanese fields for those text
blocks to eliminate the extra space.

speaker: null
- text:
original: 物有本末 事有終始
japanese: 物に本末有り、事に終始有り、
japanese: 物に本末有り、事に終始有り。
speaker: null
- text:
original: 知所先後 則近道矣
Expand Down