Makefile: fix firmware asset URL pattern (was SDDC_FX3-<tag>.img, should be SDDC_FX3.img)#25
Merged
Merged
Conversation
rx888-firmware release assets are named SDDC_FX3.img (no version suffix), not SDDC_FX3-<tag>.img. Both `make firmware` and `make firmware-latest` were constructing the wrong URL and failing with 404 against every release. Confirmed against v0.1.0: HEAD on .../SDDC_FX3.img returns 200, HEAD on .../SDDC_FX3-v0.1.0.img returns 404.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
Cause
Both
firmwareandfirmware-latesttargets build the asset URL asSDDC_FX3-<tag>.img, but rx888-firmware releases name the asset justSDDC_FX3.img(no version suffix).Confirmed against the v0.1.0 release:
.../releases/download/v0.1.0/SDDC_FX3.img.../releases/download/v0.1.0/SDDC_FX3-v0.1.0.img.../releases/download/v0.1.0/SDDC_FX3-0.1.0.imgFix
Drop the
-<tag>suffix from both URL constructions.Note (out of scope)
firmware/VERSIONon main is pinned tov0.1.0-rc1, which doesn't have a downloadableSDDC_FX3.imgasset attached. After this fix,make firmware-latestwill resolve the actual latest tag (v0.1.0) and self-heal bothfirmware/VERSIONandfirmware/SHA256SUMS. Not bumping VERSION in this PR — keeping the diff narrow to the URL fix.Generated by Claude Code