This repository was archived by the owner on Oct 28, 2025. It is now read-only.
Closed
Conversation
sappenin
commented
Sep 30, 2025
| // Step #2: Test set_data edge cases | ||
| // ######################################## | ||
| check_result( | ||
| unsafe { host_bindings_loose::get_parent_ledger_hash(-1, 4) }, |
Collaborator
Author
There was a problem hiding this comment.
Passing a negative number to get_parent_ledger_hash is not impossible per Rust type-checking.
sappenin
commented
Sep 30, 2025
| "get_parent_ledger_hash_len_too_long", | ||
| ) | ||
| }); | ||
| // NOTE: This test is commented out because the WASM runtime catches the out of bounds |
Collaborator
Author
There was a problem hiding this comment.
LMK and I'll simply remove these commented out tests. Wanted to leave them in for now to make sure we evaluate this change-set properly.
sappenin
commented
Sep 30, 2025
| error_codes::POINTER_OUT_OF_BOUNDS, | ||
| "get_tx_nested_array_len_ptr_oob", | ||
| ); | ||
| // NOTE: These tests are commented out because the WASM runtime catches the out of bounds |
Collaborator
Author
There was a problem hiding this comment.
LMK and I'll simply remove these commented out tests. Wanted to leave them in for now to make sure we evaluate this change-set properly.
sappenin
commented
Sep 30, 2025
| check_result( | ||
| unsafe { host::account_keylet(locator.as_ptr(), locator.len(), ptr, len) }, | ||
| error_codes::INVALID_PARAMS, | ||
| error_codes::BUFFER_TOO_SMALL, |
Collaborator
Author
There was a problem hiding this comment.
Not sure if these tests are potentially invalid now. @mvadari to comment.
sappenin
commented
Sep 30, 2025
mvadari
reviewed
Sep 30, 2025
Collaborator
Author
|
Closing this PR -- it doesn't seem easy (or necessary) to have codecov tests running as part of the Craft build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR removes the no-longer-used/needed
host_bindings_loose.rsandhost_bindings_loose_for_testing.rs. During implementation of this issue, it was discovered that theprojects/e2e_tests/codecov_testswere not being executed as part of thescripts/e2e-tests.shbuild step (because thecodecov_testslacked afixturesfolder, prompting that test to be ignored). This PR also restores that test and updates assertions based on real fixture data.Type of Change