100 Million ledger celebration banner #1258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuan121
reviewed
Nov 4, 2025
achowdhry-ripple
commented
Nov 4, 2025
ckeshava
reviewed
Nov 4, 2025
kuan121
approved these changes
Nov 4, 2025
ckeshava
approved these changes
Nov 4, 2025
Contributor
ckeshava
left a comment
ckeshava
left a comment
There was a problem hiding this comment.
I do not have any objections to this PR.
- Can you deploy this change on stg environment before the deployment into prod?
- Can we verify that the banner appears correctly on mobile view?
|
|
||
| const newCountdown = calculateCountdown(currentLedger) | ||
| setCountdown(newCountdown) | ||
| setIsReached(true) |
Contributor
There was a problem hiding this comment.
Are you setting isReached=true upon the reciept of a new ledger by the Explorer? I do not understand how isReached=false, if the Explorer recieves a steady stream of validated ledgers.
Collaborator
Author
There was a problem hiding this comment.
sorry had set this to true manually when demoing that state to you guys. It is back to the original logic
Collaborator
Author
|
Contributor
@ckeshava We should avoid deploying changes from open PRs directly to staging—dev exists for that purpose. The usual workflow is:
|
achowdhry-ripple
commented
Nov 5, 2025
sguntaka1578-ripple
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Adds a banner to the home page that has a countdown, and then celebrates the 100 Million ledger mark.
Context of Change
Type of Change
Codebase Modernization
Before / After
Test Plan